Add platform-specific terminal app checking

[ivan-ottinger]

Related issues

Related to STU-931

Proposed Changes

• ensure that only the terminal apps available on specific OS are listed
  • this removes iTerm and Ghostty from the Studio app on Windows

Before	After

On Monday I am planning to propose adding PowerShell as another terminal option on Windows in another PR.

→ Update: After further consideration I don't think it makes sense to add PowerShell. In the future we could consider some additional options though.

Testing Instructions

1. Check out the PR branch and build the app with npm install && npm start on Windows.
2. Head over to the app settings modal and take a look at the available Terminal options.
3. There should be only Command Prompt and Warp app options available.
4. There should be no change on the macOS Studio version.

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[github-actions]

📊 Performance Test Results

Comparing 50229b1 vs trunk

site-editor

Metric	trunk	50229b1	Diff	Change
load	13128.00 ms	15283.00 ms	+2155.00 ms	🔴 16.4%

site-startup

Metric	trunk	50229b1	Diff	Change
siteCreation	18086.00 ms	18373.00 ms	+287.00 ms	🔴 1.6%
siteStartup	4963.00 ms	4914.00 ms	-49.00 ms	🟢 -1.0%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[epeicher]

Thanks for improving this @ivan-ottinger! I have tested on both, Mac and Windows, and they display the correct Terminal applications. LGTM!

Mac	Windows

I have left a minor suggestion of refactor to consider, but feel free to progress with this version if you prefer it

[epeicher]

Non-blocking suggestion: What do you think about adding a method that returns directly the terminal supported by platform? Something like getTerminalsSupportedOnPlatform so the lib/terminal is in charge of doing the filtering? I think this leaves the filtering responsibility to the terminal lib and makes the code more maintainable.

[ivan-ottinger]

Thank you for the suggestion, Roberto! I have made the change in 6d22cf7.

I agree it is more maintainable and easier to read as well. 🙂

[epeicher]

Thanks @ivan-ottinger for addressing the comment! I’ve tested it again on Mac and Windows, and it works perfectly 🙌