Fix RTL styling on WordPress Core components - #1998
Conversation
📊 Performance Test ResultsComparing b3678f4 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
ivan-ottinger
left a comment
There was a problem hiding this comment.
Thank you for fixing the issue with the broken RTL styles, Bernardo.
The proposed code looks good to me and works correctly. When a RTL local is set, the related WordPress Core components styles are being loaded as expected.
I have tested it in the dev and also built app.
The paddings around X button in the modal and around checkboxes is now correct.
Just the unit tests need adjustment.
| id="wordpress-components-style" | ||
| href={ '../main_window/styles/wordpress-components-style.css' } | ||
| id="wordpress-components-style-error-fallback" | ||
| href={ './main_window/styles/wordpress-components-style.css' } |
There was a problem hiding this comment.
Nit: Should we apply the same logic for RTL for the errors than here https://github.com/Automattic/studio/pull/1998/files#diff-d47d7dfb85379fc920c32c6ccd0a9f5817e5104a1db25afd75a39b779fc5af70R22 ? 🤔 This is what I get
katinthehatsite
left a comment
There was a problem hiding this comment.
This works for me, I did not spot any regressions on my end 👌

Related issues
Proposed Changes
Testing Instructions
npm startnpm run makeand verify styles load correctlyPre-merge Checklist