Skip to content

Studio: Be more specific in push success email by listing individual sync elements - #2007

Merged
katinthehatsite merged 73 commits into
trunkfrom
fix/send-specific-data-to-backend-for-email
Nov 19, 2025
Merged

Studio: Be more specific in push success email by listing individual sync elements#2007
katinthehatsite merged 73 commits into
trunkfrom
fix/send-specific-data-to-backend-for-email

Conversation

@katinthehatsite

@katinthehatsite katinthehatsite commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

Related issues

Closes STU-759

Proposed Changes

  • Please refer to description and details in 195447-ghe-Automattic/wpcom

Testing Instructions

  • Please refer to the testing instructions in 195447-ghe-Automattic/wpcom

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Nov 5, 2025
@katinthehatsite
katinthehatsite marked this pull request as draft November 5, 2025 09:44
Kateryna Kodonenko added 2 commits November 5, 2025 10:46
@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 541a3e0 vs trunk

site-editor

Metric trunk 541a3e0 Diff Change
load 9898.00 ms 7465.00 ms -2433.00 ms 🟢 -24.6%

site-startup

Metric trunk 541a3e0 Diff Change
siteCreation 12980.00 ms 12008.00 ms -972.00 ms 🟢 -7.5%
siteStartup 5011.00 ms 5002.00 ms -9.00 ms 🟢 -0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@katinthehatsite
katinthehatsite requested a review from a team November 5, 2025 15:40
@katinthehatsite
katinthehatsite marked this pull request as ready for review November 5, 2025 15:40

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this. LGTM 👍

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@katinthehatsite , it works great! I tested it the PR with the backend PR 195447-ghe-Automattic/wpcom . However I noticed that we are sending paths option, which I believe is not necessary. In that case I also suggest renaming the include_path_list param to avoid confusion with a valid param that uses VaultPress.

Comment thread src/ipc-handlers.ts Outdated
@Automattic Automattic deleted a comment from claude Bot Nov 18, 2025
@Automattic Automattic deleted a comment from claude Bot Nov 18, 2025
@Automattic Automattic deleted a comment from claude Bot Nov 18, 2025

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for removing the unused paths option and renaming the param from include_path_list to list_sync_items.

I tested it and it works as expected. I received the email displaying the selected items.

While testing the PR, I found an issue, but it's also present on trunk, so let's fix it separately in STU-1003.

Let's rebase onto trunk and make sure the CI passes.

@katinthehatsite
katinthehatsite merged commit 2c5f759 into trunk Nov 19, 2025
9 checks passed
@katinthehatsite
katinthehatsite deleted the fix/send-specific-data-to-backend-for-email branch November 19, 2025 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants