Add loading check before showing empty Studio state - #2019
Merged
ivan-ottinger merged 1 commit intoNov 6, 2025
Conversation
Contributor
Author
|
We could also consider adding some loading screen, e.g. with a larger spinner (https://wordpress.github.io/gutenberg/?path=/docs/components-spinner--docs), but that would be good to have a design input on and could be handled in a separate task. What do you think? |
Contributor
📊 Performance Test ResultsComparing 2c06dc2 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
approved these changes
Nov 5, 2025
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks for solving this @ivan-ottinger! I have tested it, and I cannot see the EmptyStudi component on start. LGTM! ![]()
CleanShot.2025-11-05.at.19.17.49.mp4
Contributor
Author
|
Thank you for the review and testing, Roberto! |
ivan-ottinger
deleted the
fix/EmptyStudio-component-render-on-app-start
branch
November 6, 2025 08:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
EmptyStudiodoes not render while local sites are still loadingTesting Instructions
Basically, it should not be possible to reproduce the STU-971 issue anymore.
npm install && npm start.EmptyStudiocomponent should not render at all.Pre-merge Checklist