Studio: Update Studio deeplink URL scheme from wpcom-local-dev to wp-studio

[gavande1]

Related issues

• Fixes STU-936

Proposed Changes

• Update Studio deeplink URL scheme from wpcom-local-dev:// to wp-studio://.
• Update docs

Testing Instructions

• Check out this branch in Studio
• Run Studio. npm start
• Try to log in to the WordPress.com account
• Make sure you are logged in without any regression.

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[gcsecsey]

Thanks Rahul for tackling updating the deeplink scheme! 🙌

The changes LGTM and work well with the backend PR. I'm redirected to the app using the new scheme, and I'm logged in as expected. I experienced no regressions.

Redirect	After login

[github-actions]

📊 Performance Test Results

Comparing f8786e9 vs trunk

site-editor

Metric	trunk	f8786e9	Diff	Change
load	12154.00 ms	11878.00 ms	-276.00 ms	🟢 -2.3%

site-startup

Metric	trunk	f8786e9	Diff	Change
siteCreation	21300.00 ms	22164.00 ms	+864.00 ms	🔴 4.1%
siteStartup	10041.00 ms	11046.00 ms	+1005.00 ms	🔴 10.0%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[epeicher]

Thanks @gavande1! I have tested it, and I can see that the new protocol prefix is being used successfully. LGTM!

OAuth	After

[ivan-ottinger]

Thanks for the update, Rahul! The change looks good. I think we could also update other occurrences of wpcom-local-dev in the codebase - e.g. in the related tests and docs.

[ivan-ottinger]

One more thing: Maybe I missed it somewhere in other discussions, but what about the sync-connect-site deeplink that is still used in Calypso with the old scheme? I am guessing you are planning to update it a separate PR, right?

[gavande1]

One more thing: Maybe I missed it somewhere in other discussions, but what about the sync-connect-site deeplink that is still used in Calypso with the old scheme? I am guessing you are planning to update it a separate PR, right?

@ivan-ottinger, Yes. I am planning to address it in a separate PR. I am working on it right now. I will raise the PR soon.

[gavande1]

To close the loop, I have created Automattic/wp-calypso#107172 PR to address changes related to Calypso.

[epeicher]

Hi @gavande1. the Lint error has been fixed as part of #2082 so a merge or rebase should fix the issue

[ivan-ottinger]

Hi @gavande1. the Lint error has been fixed as part of #2082 so a merge or rebase should fix the issue

There were a couple more existing lint issues which are now addressed in #2084.

[ivan-ottinger]

I gave this a second review and test round. The changes look good and work as expected. Log in works correctly with the updated deeplink URL. 👍🏼

We just need a rebase. 🙂

[gavande1]

Thanks @epeicher and @ivan-ottinger. I have updated the branch with master. The tests should pass now.

[gavande1]

@gcsecsey and @ivan-ottinger, what do you think about merging this? It might affect the auth flow, but smoke testing should uncover any problems. I believe it's safe to go ahead with merging this.

[gcsecsey]

Thanks @gavande1 for following up on this and updating the tests! I also gave this another test and the deeplink flows work as described. 👍

@gcsecsey and @ivan-ottinger, what do you think about merging this? It might affect the auth flow, but smoke testing should uncover any problems. I believe it's safe to go ahead with merging this.

I agree, I think the Studio side changes are good to go and as we've merged 195524-ghe-Automattic/wpcom previously, we shouldn't see any regressions.

[ivan-ottinger]

Yeah, I agree we can marge this one - unless @nightnei has any objections as the release wrangler. 🙂

→ Asked in p1763628611277539/1763546848.727229-slack-C04GESRBWKW.