Skip to content

Fix Log out button not having bottom border when focused - #2088

Merged
wojtekn merged 1 commit into
trunkfrom
fix/log-out-button-click-bottom-border
Nov 19, 2025
Merged

Fix Log out button not having bottom border when focused#2088
wojtekn merged 1 commit into
trunkfrom
fix/log-out-button-click-bottom-border

Conversation

@epeicher

@epeicher epeicher commented Nov 18, 2025

Copy link
Copy Markdown
Contributor

Related issues

N/A

Proposed Changes

  • Add some padding to container of Log out button to avoid losing the bottom border when focused
Before After
CleanShot 2025-11-18 at 20 00 15@2x CleanShot 2025-11-18 at 19 59 35@2x

Testing Instructions

  • Apply this branch and run npm start
  • Log in to WordPress.com if you are not already, and click on the user on the top navigation bar
  • Press Tab until you see that the focus is set to the Log out button
  • Verify that all the borders are visible

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@epeicher
epeicher requested a review from a team November 18, 2025 19:03
@epeicher epeicher self-assigned this Nov 18, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 61de2cd vs trunk

site-editor

Metric trunk 61de2cd Diff Change
load 12461.00 ms 11388.00 ms -1073.00 ms 🟢 -8.6%

site-startup

Metric trunk 61de2cd Diff Change
siteCreation 21221.00 ms 27418.00 ms +6197.00 ms 🔴 29.2%
siteStartup 6992.00 ms 5965.00 ms -1027.00 ms 🟢 -14.7%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixes the issue:

Image
@wojtekn
wojtekn merged commit 123579e into trunk Nov 19, 2025
10 checks passed
@wojtekn
wojtekn deleted the fix/log-out-button-click-bottom-border branch November 19, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants