Skip to content

Studio: Add translations for Playground CLI console messages during site creation - #2110

Merged
epeicher merged 2 commits into
trunkfrom
stu-981-missing-translations-for-steps-displayed-when-adding-site
Nov 24, 2025
Merged

Studio: Add translations for Playground CLI console messages during site creation#2110
epeicher merged 2 commits into
trunkfrom
stu-981-missing-translations-for-steps-displayed-when-adding-site

Conversation

@epeicher

@epeicher epeicher commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Updated formatMessageForUI() function to wrap all user-facing console messages with translation calls

Testing Instructions

  • Change your system language to a non-English language that Studio supports (e.g., Spanish, French, German, Polish). Please note that most of the strings need to be translated
  • Create a new site in Studio
  • Observe the loading messages that appear during site creation
  • Verify that the console messages are displayed in the selected language instead of English

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@epeicher epeicher self-assigned this Nov 21, 2025
@epeicher
epeicher marked this pull request as ready for review November 21, 2025 16:43
@epeicher
epeicher requested a review from a team November 21, 2025 16:48
@github-actions

github-actions Bot commented Nov 21, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 04dd593 vs trunk

site-editor

Metric trunk 04dd593 Diff Change
load 16161.00 ms 15279.00 ms -882.00 ms 🟢 -5.5%

site-startup

Metric trunk 04dd593 Diff Change
siteCreation 34530.00 ms 29640.00 ms -4890.00 ms 🟢 -14.2%
siteStartup 11125.00 ms 12137.00 ms +1012.00 ms 🔴 9.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

I couldn't see the translation yet, but I can see the new messages in english

Image
@wojtekn

wojtekn commented Nov 24, 2025

Copy link
Copy Markdown
Contributor

@epeicher , would it make sense to add an inline code comment referencing the Playground CLI source to make any future updates to that easier?

@epeicher
epeicher merged commit e411387 into trunk Nov 24, 2025
9 checks passed
@epeicher
epeicher deleted the stu-981-missing-translations-for-steps-displayed-when-adding-site branch November 24, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants