Skip to content

Rename Windows updates appending suffix -full.nupkg - #2119

Merged
sejas merged 1 commit into
trunkfrom
update/stu-1043-rename-windows-updates-with-suffix-full
Nov 25, 2025
Merged

Rename Windows updates appending suffix -full.nupkg#2119
sejas merged 1 commit into
trunkfrom
update/stu-1043-rename-windows-updates-with-suffix-full

Conversation

@sejas

@sejas sejas commented Nov 25, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Rename Windows updates to finish in -full.nupkg

Testing Instructions

  • I already tested this PR by uploading the 1.6.4 versions.
  • Download the Windows update files from Buildkite in out/make/squirrel.windows/arm64 and x64
  • Comment other builds that you won't test in

    studio/fastlane/Fastfile

    Lines 140 to 217 in c2d8b12

    update_builds = {
    x64: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-x64', 'Studio.app.zip'),
    name: 'Mac Intel',
    platform: 'Mac - Intel',
    arch: 'x64',
    install_type: 'Update',
    sha: commit_hash
    },
    arm64: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-arm64', 'Studio.app.zip'),
    name: 'Mac Apple Silicon',
    platform: 'Mac - Silicon',
    arch: 'arm64',
    install_type: 'Update',
    sha: commit_hash
    },
    windows_update: {
    binary_path: File.join(BUILDS_FOLDER, 'make', 'squirrel.windows', 'x64', "studio-update.nupkg"),
    name: 'Windows - x64 Update',
    platform: 'Windows - x64',
    arch: 'x64',
    install_type: 'Update',
    sha: get_windows_update_release_sha(arch: 'x64')
    },
    windows_arm64_update: {
    binary_path: File.join(BUILDS_FOLDER, 'make', 'squirrel.windows', 'arm64', "studio-update.nupkg"),
    name: 'Windows - ARM64 Update',
    platform: 'Windows - ARM64',
    arch: 'arm64',
    install_type: 'Update',
    sha: get_windows_update_release_sha(arch: 'arm64')
    }
    }
    full_install_builds = {
    x64_dmg: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-x64.dmg'),
    name: 'Mac Intel (DMG)',
    platform: 'Mac - Intel',
    arch: 'x64',
    install_type: 'Full Install'
    },
    arm64_dmg: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-darwin-arm64.dmg'),
    name: 'Mac Apple Silicon (DMG)',
    platform: 'Mac - Silicon',
    arch: 'arm64',
    install_type: 'Full Install',
    },
    windows: {
    binary_path: File.join(BUILDS_FOLDER, 'make', 'squirrel.windows', 'x64', 'studio-setup.exe'),
    name: 'Windows - x64',
    platform: 'Windows - x64',
    arch: 'x64',
    install_type: 'Full Install'
    },
    windows_arm64: {
    binary_path: File.join(BUILDS_FOLDER, 'make', 'squirrel.windows', 'arm64', 'studio-setup.exe'),
    name: 'Windows - ARM64',
    platform: 'Windows - ARM64',
    arch: 'arm64',
    install_type: 'Full Install'
    },
    windows_appx_unsigned: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-appx-x64-unsigned', "Studio #{appx_version} unsigned.appx"),
    name: 'Windows - x64 (Unsigned Appx)',
    platform: 'Microsoft Store - x64',
    arch: 'x64',
    install_type: 'Full Install',
    },
    windows_arm64_appx_unsigned: {
    binary_path: File.join(BUILDS_FOLDER, 'Studio-appx-arm64-unsigned', "Studio #{appx_version} unsigned.appx"),
    name: 'Windows - ARM64 (Unsigned Appx)',
    platform: 'Microsoft Store - ARM64',
    arch: 'arm64',
    install_type: 'Full Install',
    },
    , or if you want to test all follow the testing steps from Migrate release uploads to Apps CDN #1422
  • Run bundle install
  • Run DRY_RUN=true BUILDKITE_BUILD_NUMBER=9237 BUILDKITE_TAG=v1.6.4 bundle exec fastlane distribute_release_build
  • Observe the renamed files in your out folder.
Screenshot 2025-11-25 at 10 31 12

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas
sejas requested a review from a team November 25, 2025 10:31
@sejas sejas self-assigned this Nov 25, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing a082ada vs trunk

site-editor

Metric trunk a082ada Diff Change
load 14562.00 ms 11909.00 ms -2653.00 ms 🟢 -18.2%

site-startup

Metric trunk a082ada Diff Change
siteCreation 23212.00 ms 22195.00 ms -1017.00 ms 🟢 -4.4%
siteStartup 9078.00 ms 9021.00 ms -57.00 ms 🟢 -0.6%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! It works as described. LGTM 👍

Image
@sejas
sejas merged commit dda5008 into trunk Nov 25, 2025
10 checks passed
@sejas
sejas deleted the update/stu-1043-rename-windows-updates-with-suffix-full branch November 25, 2025 11:53

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to test this and it works as expected. LGTM! :shipit:

Running fastlane Renamed files
Image Image
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants