Skip to content

Make build-for-windows.ps1 fail if install-node-dependencies.sh fails #2120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredrikekelund merged 2 commits into from
Nov 25, 2025
Merged

Make build-for-windows.ps1 fail if install-node-dependencies.sh fails #2120

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
39f58bd
Pass -eu flag to bash when running npm install script on Windows
fredrikekelund Nov 25, 2025
42e3bd9
Move -eu flags to install-node-dependencies.sh
fredrikekelund Nov 25, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions .buildkite/commands/install-node-dependencies.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
#!/bin/bash -eu
#!/bin/bash

set -eu

PLATFORM=$(uname -s)
ARCHITECTURE=$(uname -m)
Expand Down Expand Up @@ -42,12 +44,13 @@ npm ci \
--maxsockets "$MAX_SOCKETS" \
"$@"

cd cli; npm ci \
cd cli
npm ci \
--prefer-offline \
--no-audit \
--no-progress \
--maxsockets "$MAX_SOCKETS"; \
cd -
--maxsockets "$MAX_SOCKETS"
cd -

echo "--- :npm: Save cache if necessary"
# Notice that we don't cache the local node_modules.
Expand Down