Skip to content

Fix close modal when adding a blank site - #2163

Merged
sejas merged 1 commit into
trunkfrom
fix/stu-1072-close-modal-as-first-action
Dec 2, 2025
Merged

Fix close modal when adding a blank site#2163
sejas merged 1 commit into
trunkfrom
fix/stu-1072-close-modal-as-first-action

Conversation

@sejas

@sejas sejas commented Dec 2, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Make sure the add site modal closes after creating the site

Testing Instructions

  • Click on "Add Site" in the left sidebar.
  • Click on "Create a blank site"
  • Continue the process
  • Observe that the modal closes the moment that you click the last "Add site" button

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Dec 2, 2025
@sejas
sejas requested a review from a team December 2, 2025 00:10
@github-actions

github-actions Bot commented Dec 2, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 2cc30b2 vs trunk

site-editor

Metric trunk 2cc30b2 Diff Change
load 13075.00 ms 16841.00 ms +3766.00 ms 🔴 28.8%

site-startup

Metric trunk 2cc30b2 Diff Change
siteCreation 23591.00 ms 22911.00 ms -680.00 ms 🟢 -2.9%
siteStartup 10052.00 ms 9028.00 ms -1024.00 ms 🟢 -10.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas

sejas commented Dec 2, 2025

Copy link
Copy Markdown
Member Author

E2E had a timeout on Windows: 1) e2e\site-navigation.test.ts:100:6 › Site Navigation › creates a post

@sejas
sejas merged commit 32683da into trunk Dec 2, 2025
9 of 10 checks passed
@sejas
sejas deleted the fix/stu-1072-close-modal-as-first-action branch December 2, 2025 00:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant