Skip to content

Change texts in authentication onboarding - #2176

Merged
sejas merged 4 commits into
trunkfrom
update/stu-1083-studio-change-the-texts-in-authentication-onboarding
Dec 3, 2025
Merged

Change texts in authentication onboarding#2176
sejas merged 4 commits into
trunkfrom
update/stu-1083-studio-change-the-texts-in-authentication-onboarding

Conversation

@sejas

@sejas sejas commented Dec 3, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • Change texts in onboarding Studio

Testing Instructions

  • Remove all your sites
  • Remove the onboardingCompleted from your ~/Library/Application Support/Studio/appdata-v1.json
  • Run npm start
  • Confirm the onboarding looks as expected
Before After
Screenshot 2025-12-03 at 12 29 41 Screenshot 2025-12-03 at 12 29 22

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Dec 3, 2025
@sejas
sejas requested a review from a team December 3, 2025 12:31
@sejas sejas changed the title Update/stu 1083 studio change the texts in authentication onboarding Dec 3, 2025
@github-actions

github-actions Bot commented Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 54d7a11 vs trunk

site-editor

Metric trunk 54d7a11 Diff Change
load 13781.00 ms 14470.00 ms +689.00 ms 🔴 5.0%

site-startup

Metric trunk 54d7a11 Diff Change
siteCreation 30402.00 ms 26773.00 ms -3629.00 ms 🟢 -11.9%
siteStartup 10042.00 ms 10061.00 ms +19.00 ms 🔴 0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change
gcsecsey
gcsecsey approved these changes Dec 3, 2025
View reviewed changes

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The updated copies LGTM 👍

Image
nightnei
nightnei reviewed Dec 3, 2025
View reviewed changes
Comment thread e2e/page-objects/onboarding.ts
return this.locator.getByRole( 'heading', {
name: /Connect to your WordPress.com account|Connect your WordPress.com account/,
} );
return this.locator.getByTestId( 'onboarding-welcome-title' ).or(

@nightnei nightnei Dec 3, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not something that should be done, I am just thinking for the future cases - are there some disadvantages of using data-testid vs roles 🤔 Interesting your thoughts why you decided to switch to testid?

@sejas sejas Dec 3, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I decided to use testId because this flow is used in every e2e and performance metric, so changing the text becomes more tricky as we need to support both text for a bit. Using only role could work, but I want to make sure the Heading displayed is this one and not the Add site flow.
I'll remove the text selector after a few days in favor of the testId.
nightnei
nightnei approved these changes Dec 3, 2025
View reviewed changes

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@sejas
sejas merged commit 3a0cc69 into trunk Dec 3, 2025
10 of 11 checks passed
@sejas
sejas deleted the update/stu-1083-studio-change-the-texts-in-authentication-onboarding branch December 3, 2025 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@sejas @nightnei @gcsecsey