Add loading and empty placeholders to the list of sites - #2190
Merged
sejas merged 3 commits intoDec 5, 2025
Merged
Conversation
Contributor
📊 Performance Test ResultsComparing 4e86e0a vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
…udio-add-loading-state-in-import-remote-site-site-creation
bcotrim
reviewed
Dec 4, 2025
Member
We are tackling that under STU-1085 |
sejas
approved these changes
Dec 5, 2025
sejas
deleted the
stu-1080-studio-add-loading-state-in-import-remote-site-site-creation
branch
December 5, 2025 08:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related issues
Proposed Changes
SyncSitesSelectormodal to an external component and uses it as part of thepull-remote-sitecomponent so both uses the sameLoading...and empty search logicBefore
CleanShot.2025-12-04.at.13.11.46.mp4
After
CleanShot.2025-12-04.at.13.10.00.mp4
Testing Instructions
npm startAdd siteand selectPull an existing siteLoading...while the sites are loaded, if not you can hitCmd+Rin dev to refresh the data and repeat the stepNo sites found for...Regression testing
Pre-merge Checklist