Display the plans modal in the pull an existing site creation flow

[sejas]

Related issues

• Fixes STU-1085

Proposed Changes

• Display NoWpcomSitesModal for new users without any site.
• Updated the purchase button to don't add studioSiteId when running the pull an existing site creation flow.

Testing Instructions

• Logout
• Run npm start
• Click Add site > Pull an existing site
• Login or create a new account without any sites
• Observe that the modal appears
• Close the modal
• Go back
• Repeat
• Confirm that the modal appears again
• Remove all sites to display the empty state
• Confirm that the same behaviour occurs

show-modal-empty-state.mp4

find-a-perfect-plan-when-pulling-an-existing-site.mp4

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[katinthehatsite]

I think in terms of functionality it works fine but I am finding it strange that we display the modal in front of sort of "another modal" with the site search. To me, it would make sense to directly display the information from the NoWpcomSites modal on the screen without having the modal popup when the user logs in. I feel like this would make the design more coherent.

What do you think?

If this needs to be urgently merged before the release, we can do that and then do a follow up to improve the design as an alternative.

[sejas]

@katinthehatsite , thanks for the review and for bring it up your concern. I agree that two modals seem a bit strange, although that was the design of @Marinatsu. See p58i-ofU-p2

[github-actions]

📊 Performance Test Results

Comparing 0b08bf9 vs trunk

site-editor

Metric	trunk	0b08bf9	Diff	Change
load	12707.00 ms	15283.00 ms	+2576.00 ms	🔴 20.3%

site-startup

Metric	trunk	0b08bf9	Diff	Change
siteCreation	15247.00 ms	18569.00 ms	+3322.00 ms	🔴 21.8%
siteStartup	5966.00 ms	6961.00 ms	+995.00 ms	🔴 16.7%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[katinthehatsite]

I created a follow up issue to adjust the background here: https://linear.app/a8c/issue/STU-1113/studio-improve-plans-modal-in-the-pull-during-existing-site-creation