Skip to content

Enable fs-ext - #2200

Merged
bcotrim merged 1 commit into
trunkfrom
add/fs-ext-file-locking
Dec 9, 2025
Merged

Enable fs-ext#2200
bcotrim merged 1 commit into
trunkfrom
add/fs-ext-file-locking

Conversation

@bcotrim

@bcotrim bcotrim commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

Related issues

  • N/A

Proposed Changes

  • Enable building fs-ext

Testing Instructions

  • npm install
  • npm start
  • Start a Studio site and check the logs (we no longer see a fs-ext warning)
Before After
Screenshot 2025-12-05 at 10 58 11 image

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim
bcotrim requested a review from a team December 5, 2025 11:00
@bcotrim bcotrim self-assigned this Dec 5, 2025
@github-actions

github-actions Bot commented Dec 5, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 57ea76f vs trunk

site-editor

Metric trunk 57ea76f Diff Change
load 8248.00 ms 9490.00 ms +1242.00 ms 🔴 15.1%

site-startup

Metric trunk 57ea76f Diff Change
siteCreation 23606.00 ms 24988.00 ms +1382.00 ms 🔴 5.9%
siteStartup 12132.00 ms 11032.00 ms -1100.00 ms 🟢 -9.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM and I confirm not getting the error:

Image
@bcotrim
bcotrim merged commit de65133 into trunk Dec 9, 2025
9 checks passed
@bcotrim
bcotrim deleted the add/fs-ext-file-locking branch December 9, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants