Refactor blueprint deeplink handling in the Add site modal - #2216
Merged
Conversation
ivan-ottinger
force-pushed
the
add/add-site-context
branch
2 times, most recently
from
December 9, 2025 11:58
94d3f63 to
d1688eb
Compare
AddSiteProvider to handle states related to site creation modal….tsx && git rebase --continue 2>&1 Refactor deeplink handling to use AddSiteProvider context
ivan-ottinger
force-pushed
the
add/add-site-context
branch
from
December 10, 2025 09:36
8553a4c to
0d040d0
Compare
ivan-ottinger
marked this pull request as ready for review
December 10, 2025 09:50
Contributor
📊 Performance Test ResultsComparing 007e9fc vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
sejas
approved these changes
Dec 10, 2025
sejas
left a comment
Member
There was a problem hiding this comment.
Thanks for cleaning the code and removing AddSiteContentWithDeeplinkSupport, now the logic is much clearer.
I tested creating the 4 types of sites as first site and as second sites, and I didn't see any regression. The issue STU-1121 is still present, but we'll tackle that in a separate PR.
gcsecsey
reviewed
Dec 10, 2025
gcsecsey
left a comment
Member
There was a problem hiding this comment.
I also tested this and found no regressions with either creating the sites or running the Blueprints via deeplinks.
Thank you for carrying out the refactor, Ivan! IMO this structure is much clearer.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
The goal of this PR is to streamline the handling of blueprint deeplinks in the Add site modal and improve maintainability. We are getting rid of 34 lines of code.
AddSiteContentWithDeeplinkSupportcomponentuseAddSiteTesting Instructions
npm install && npm start.or the ones in https://jsbin.com/levaburate/2/edit?html,css,output .
Pre-merge Checklist