Reset file import state on Add site modal close - #2220
Merged
ivan-ottinger merged 2 commits intoDec 9, 2025
Conversation
ivan-ottinger
marked this pull request as ready for review
December 9, 2025 10:56
epeicher
approved these changes
Dec 9, 2025
Contributor
There was a problem hiding this comment.
T/hanks @ivan-ottinger for fixing this! I have tested it, and I can confirm that the file is not displayed anymore on the modal after applying this branch, while I was able to reproduce it in trunk. Changes LGTM! 
gcsecsey
approved these changes
Dec 9, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
Thanks for improving this @ivan-ottinger! This LGTM and works well:
CleanShot.2025-12-09.at.11.07.42.mp4
Contributor
📊 Performance Test ResultsComparing d118401 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
ivan-ottinger
deleted the
add/add-site-import-state-clear-on-modal-close
branch
December 9, 2025 11:46
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Add sitemodal closeTesting Instructions
npm install && npm start.Add sitebutton to open the modal and select "Import from a backup" option.Add sitebutton again.Pre-merge Checklist