Studio: Ensure the add site screen can be dragged by the header - #2232
Merged
Conversation
katinthehatsite
marked this pull request as draft
December 10, 2025 14:18
Contributor
📊 Performance Test ResultsComparing 043bb7b vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
…d-site-screen-draggable
Contributor
Author
|
This will make the behaviour of the app consistent with other screens. One thing is that we don't have any visual indication where the header is on that screen but we would need reconsider design for that case. |
katinthehatsite
marked this pull request as ready for review
December 11, 2025 08:49
epeicher
approved these changes
Dec 11, 2025
epeicher
left a comment
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks @katinthehatsite for fixing this! I have tested it, and it works as expected, I can move the Studio window when I'm adding a site. LGTM!
CleanShot.2025-12-11.at.10.22.38.mp4
gavande1
approved these changes
Dec 11, 2025
gavande1
left a comment
gavande1
left a comment
Contributor
There was a problem hiding this comment.
I tested it and it works as expected. LGTM 👍
CleanShot.2025-12-11.at.15.02.10.mp4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Fixes STU-1076
Proposed Changes
This PR ensures that Studio app can be dragged by the top header when the user is on the
Add sitescreen:Testing Instructions
npm startAdd sitePre-merge Checklist