Fix auto-updates on app launch by setting the value in NODE_ENV - #2234
Merged
sejas merged 2 commits intoDec 10, 2025
Conversation
Contributor
📊 Performance Test ResultsComparing eefa717 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
epeicher
approved these changes
Dec 10, 2025
epeicher
left a comment
Contributor
There was a problem hiding this comment.
Thanks @sejas! I have tested this, and it works as expected. I don't see the env and I can see the skipping message in the previous version, while I now see the environments, both production and development, and I don't see the skipping message in Production anymore. LGTM! ![]()
| Trunk | This branch production | This branch development |
|---|---|---|
![]() |
![]() |
![]() |
sejas
deleted the
fix/stu-1122-auto-updates-not-triggering-on-app-launch
branch
December 10, 2025 18:25
Contributor
|
@sejas thanks for the fix! Which version introduced that issue? |
Member
Author
|
The issue was introduced in Studio v1.6.0 when we switched to Vite. I also confirmed that auto-updates worked as expected in the previous version v1.5.6 ( pfHvTO-Au-p2 ) |
Contributor
|
Thanks for confirming that @sejas . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related issues
Proposed Changes
process.env.NODE_ENVto the packaged versionNODE_ENVto beproduction. See:studio/src/updates.ts
Lines 22 to 24 in acacf62
Testing Instructions
Production
~/Library/Logs/Studio/studio-20251210.0.lognpm install && npm run makeout/makeSkipping auto-updates:Development
npm startdevelopment:Before this changes NODE_EN was undefined
If you remove the line added in
electron.vite.config.ts, and then make another build, then you'll see how NODE_ENV was undefined with this output in the log:Pre-merge Checklist