Show loading screen while fetching sites in Pull an existing site modal

[epeicher]

Related issues

• Solves STU-1125
• Related to Studio: Improve plans modal in the pull during existing site creation flow #2222
• Related to Studio: Show all WordPress.com sites when importing, not just unconnected ones #2235

Proposed Changes

• Show the original modal while fetching the sites with the Loading… message

CleanShot.2025-12-11.at.14.37.39.mp4

Testing Instructions

• Apply this branch and run npm start
• When opening studio, click on Add site and Pull an existing site
• Check there is a Loading… message, if you cannot see the message, try CMD+R to refresh data
• Verify that the test steps on linked PR Studio: Improve plans modal in the pull during existing site creation flow #2222 still work as expected

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[github-actions]

📊 Performance Test Results

Comparing 046d1df vs trunk

site-editor

Metric	trunk	046d1df	Diff	Change
load	11114.00 ms	10195.00 ms	-919.00 ms	🟢 -8.3%

site-startup

Metric	trunk	046d1df	Diff	Change
siteCreation	22552.00 ms	18586.00 ms	-3966.00 ms	🟢 -17.6%
siteStartup	9026.00 ms	7020.00 ms	-2006.00 ms	🟢 -22.2%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[katinthehatsite]

Thanks for fixing this, this worked as expected for me 👍

[ivan-ottinger]

Thanks for the fix, Roberto! The loading message is displaying as expected and the experience is more clear now. 👍🏼

I have noticed one issue - the scrollbars are displayed on the side like this:

Some local sites already exist:

CleanShot.2025-12-11.at.17.07.59.mp4

No local sites:

CleanShot.2025-12-11.at.17.12.29.mp4

[epeicher]

Thanks @katinthehatsite and @ivan-ottinger for your reviews!

I have noticed one issue - the scrollbars are displayed on the side like this:

Well spotted! That was an existing issue, but I have fixed it as part of f5594d4. Now the list of sites is no longer rendered while sites are loading. I have also refactored the component a bit for better readability.

[ivan-ottinger]

Well spotted! That was an existing issue, but I have fixed it as part of f5594d4. Now the list of sites is no longer rendered while sites are loading. I have also refactored the component a bit for better readability.

Thank you for addressing that, Roberto! I can confirm the loading is now working correctly! 👌🏼

[sejas]

Thanks for bringing back the loading state.
I confirm it works great. I also tested it with a user without no sites, where it appears the loading state and then switches to the Purchase CTA.
For regular users, the loading state only takes a fraction to load, which is great.