-
Notifications
You must be signed in to change notification settings - Fork 86
Add Xdebug support #2242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Xdebug support #2242
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
bbd313c
Add type definitions for Xdebug support
wojtekn 8ff5cf1
Add Xdebug Support beta feature definition
wojtekn ed67c08
Add IPC handler to find Xdebug-enabled site
wojtekn 42d1303
Use enableXdebug option instead of hardcoded condition
wojtekn 84bab4b
Thread enableXdebug option through Playground CLI provider
wojtekn 6f8925f
Pass enableXdebug from site details to provider
wojtekn 5b7df93
Expose getXdebugEnabledSite handler in preload script
wojtekn 1985cea
Fix preserving Xdebug option in files
wojtekn 7b39fc0
Add Xdebug UI in site edit form
wojtekn 3d437a7
Fix comparison to accep undefined value
wojtekn a2d06ac
Add test case for getXdebugEnabledSite
wojtekn 98aa2af
Remove unnecessary commented out code
wojtekn 403aa0c
Add Xdebug status in Site details in Settings tab
wojtekn 0f052c8
Grey out the Xdebug section if it is disabled
wojtekn a8082b2
Simplify Xdebug UI, add learn more link, improve disabled styling
wojtekn 6fc59e4
Update test to account for Disabled Xdebug option
wojtekn 09be845
Remove bold to unify label with other parts
wojtekn 3241fe7
Wrap Xdebug in site Settings with beta feature flag check
wojtekn ff3cb45
Fix tests
wojtekn 54cc6b7
Add missing enableXdebug
wojtekn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also add
experimentalUnsafeIdeIntegrationargument or is not necessary? I tried it to add it, but it didn't help during my testing.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, because it's experimental and unsafe :D I tested it, and besides being broken, it was only updating IDE configs. I think it's better if Studio enables user to use Xdebug, instead of modifying their IDE configs.