Skip to content

Render app arch inside About dialog - #2244

Merged
nightnei merged 2 commits into
trunkfrom
studioArchInAbout
Dec 15, 2025
Merged

Render app arch inside About dialog#2244
nightnei merged 2 commits into
trunkfrom
studioArchInAbout

Conversation

@nightnei

@nightnei nightnei commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

Proposed Changes

I am working on STU-1069, and I didn't know how to determine whether the arm version is installed or not. I had an assumption that maybe the bug is on the frontend and it's just UI bug. I decided that would be usefull to somewhere render the arch. So I added it as a title for the Studio version, to avoid being intrusive in the dialog. I think it will be useful for our team in the future.

Testing Instructions

  1. Build Studio and run it on macOS and Windows.
  2. Assert that you see correct app version and arch inside About window
    Screenshot 2025-12-12 at 15 58 09
@nightnei
nightnei requested a review from a team December 12, 2025 12:19
@nightnei nightnei self-assigned this Dec 12, 2025
Comment thread src/about-menu/open-about-menu.ts Outdated
document.title = '${ aboutStudioText }';
document.getElementById('studio-by-wpcom').innerText = '${ studioByWpcomText }';
document.getElementById('version-text').innerText = '${ versionText }';
document.getElementById('version-text').title = '${ systemInfoTooltip }';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, this information is essential for debugging, and it would be great if users could copy-paste it. What if we included it inline, in brackets, after the version?

@nightnei nightnei Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we included it inline

I am totally on board with it. Actually, it was what I did initially, but then decided to hide 😄

Comment thread src/about-menu/open-about-menu.ts Outdated
const arch = process.arch;

if ( platform === 'darwin' ) {
return arch === 'arm64' ? 'macOS Apple Silicon' : 'macOS Intel';

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if we aligned those options with the exact wording we use on the landing page?

@github-actions

github-actions Bot commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing d6456eb vs trunk

site-editor

Metric trunk d6456eb Diff Change
load 9628.00 ms 11293.00 ms +1665.00 ms 🔴 17.3%

site-startup

Metric trunk d6456eb Diff Change
siteCreation 30205.00 ms 19338.00 ms -10867.00 ms 🟢 -36.0%
siteStartup 11009.00 ms 7973.00 ms -3036.00 ms 🟢 -27.6%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@bcotrim

bcotrim commented Dec 12, 2025

Copy link
Copy Markdown
Contributor

The changes are quite readable in the code, and it will take a lot of time to generate all builds and test them. So I propose just to trust that I have tested it, to save your time :)

You should be able to trigger a build on CI and reviewers could use the generated artifacts to validate the changes without needing to build locally.

@nightnei

nightnei commented Dec 12, 2025

Copy link
Copy Markdown
Contributor Author

I printed arch and made the line selectable.
I wanted to add "Copy" button, but I think it's overkill for this case, because it's necessary to use IPC, since browser's clipboard doesn't work in Electron. And I tried to include preload from main window, but it feels too much and also there we have validation issues. I was thinking about implementing own preload for About window, but in teh result I decided that it's too much code and it doesn't worth it. So as a result, I think that the best is to go with just a selectable line of text.
Screenshot 2025-12-12 at 15 58 09

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good:

Apple Silicon Chip Intel Chip
Image Image

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it on Mac and it works as expected. I tested it in English and Spanish.

English Spanish
Image Image
@nightnei
nightnei merged commit ea25a95 into trunk Dec 15, 2025
10 checks passed
@nightnei
nightnei deleted the studioArchInAbout branch December 15, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants