Skip to content

Unify add site props - #2246

Closed
sejas wants to merge 4 commits into
trunkfrom
update/unify-add-site-props-in-add-site-flow-components
Closed

Unify add site props#2246
sejas wants to merge 4 commits into
trunkfrom
update/unify-add-site-props-in-add-site-flow-components

Conversation

@sejas

@sejas sejas commented Dec 12, 2025

Copy link
Copy Markdown
Member

Related issues

Proposed Changes

  • This PR doesn't add new functionality. It just simplifies the prop drilling to use only one prop. In future refactors we can consider using a Redux slice to remove the addSiteProps prop too.

Testing Instructions

  • This PR doesn't add or modify any feature. We need to confirm there are no regressions.
  • Run npm start
  • Click on Add site
  • Try the four options
  • Confirm there are no regressions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Dec 12, 2025
@sejas
sejas marked this pull request as ready for review December 31, 2025 00:18
@sejas
sejas requested a review from a team December 31, 2025 00:18
@katinthehatsite

katinthehatsite commented Dec 31, 2025

Copy link
Copy Markdown
Contributor

Just the heads up that we have a very similar PR in #2309 that closes https://linear.app/a8c/issue/STU-1099/studio-refactor-createsiteform-to-reduce-props-drilling
@sejas

sejas commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

Then I'll close this PR! 👌
Thanks Kat!
@sejas sejas closed this Jan 7, 2026
@wojtekn
wojtekn deleted the update/unify-add-site-props-in-add-site-flow-components branch January 12, 2026 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewer can merge

2 participants

@sejas @katinthehatsite