Studio: Ensure the site can't be deleted when syncing

[katinthehatsite]

Related issues

Fixes STU-1127

Proposed Changes

This PR ensures that the local site can not be deleted when syncing to WP.com (either pulling or pushing).

Testing Instructions

• Pull the changes from this branch
• Start Studio
• Navigate to the Sync tab
• Connect a site
• Start either push or pull
• Navigate to the Settings tab
• Click on the three ellipsis in the right corner
• Confirm that the Delete site button is disabled and the site can not be deleted
• Try to delete the Studio site from the context menu
• Confirm that the Delete site button is disabled

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[github-actions]

📊 Performance Test Results

Comparing d8fe9dc vs trunk

site-editor

Metric	trunk	d8fe9dc	Diff	Change
load	15230.00 ms	13719.00 ms	-1511.00 ms	🟢 -9.9%

site-startup

Metric	trunk	d8fe9dc	Diff	Change
siteCreation	25904.00 ms	26553.00 ms	+649.00 ms	🔴 2.5%
siteStartup	11048.00 ms	8995.00 ms	-2053.00 ms	🟢 -18.6%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[ivan-ottinger]

Thank you for the fix, Kat! I have observed one inconsistency where the Delete site... button in the Settings tab is disabled for the whole process, while the similar option in the sidebar dropdown gets disabled only for a small part of the process:

CleanShot.2025-12-17.at.13.42.06.mp4

[katinthehatsite]

Thank you for the fix, Kat! I have observed one inconsistency where the Delete site... button in the Settings tab is disabled for the whole process, while the similar option in the sidebar dropdown gets disabled only for a small part of the process:

👀

[katinthehatsite]

Great catch @ivan-ottinger - it should be fixed now. Would you be able to give it another try? Thank you!

[ivan-ottinger]

Great catch @ivan-ottinger - it should be fixed now. Would you be able to give it another try? Thank you!

Thanks for the fix, Kat. The changes work as expected (bot delete buttons are now disabled in the same way). The code looks generally good to me. I have just shared one suggestion and noticed that tests are failing.

[gcsecsey]

Thanks @katinthehatsite for working on this! I tested both pushing and pulling and now I confirm not being able to delete the site for the whole duration, either from the sidebar or from the Settings tab.

CleanShot.2025-12-17.at.17.24.18.mp4

[ivan-ottinger]

Thanks for the updates, Kat! All is looking good to me now. ✅