Skip to content

Update Electron and Vite packages - #2258

Merged
wojtekn merged 2 commits into
trunkfrom
update/electron-and-vite-packages
Dec 16, 2025
Merged

Update Electron and Vite packages#2258
wojtekn merged 2 commits into
trunkfrom
update/electron-and-vite-packages

Conversation

@wojtekn

@wojtekn wojtekn commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Related issues

  • N/A

Proposed Changes

  • I propose updating Electron and Vite packages.

Testing Instructions

  • Confirm builds go through.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn wojtekn self-assigned this Dec 16, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing b718603 vs trunk

site-editor

Metric trunk b718603 Diff Change
load 13487.00 ms 14501.00 ms +1014.00 ms 🔴 7.5%

site-startup

Metric trunk b718603 Diff Change
siteCreation 24598.00 ms 26716.00 ms +2118.00 ms 🔴 8.6%
siteStartup 9036.00 ms 10066.00 ms +1030.00 ms 🔴 11.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@wojtekn
wojtekn requested a review from a team December 16, 2025 12:07

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build went through without any issues. I left a question out of curiosity, but changes LGTM! :shipit:

Comment thread .nvmrc
@wojtekn
wojtekn merged commit 1193416 into trunk Dec 16, 2025
11 checks passed
@wojtekn
wojtekn deleted the update/electron-and-vite-packages branch December 16, 2025 16:50
@fredrikekelund

Copy link
Copy Markdown
Contributor

The electron-vite upgrade to v5.0.0 comes with breaking changes. We are now using a deprecated API in electron.vite.config.ts. See https://electron-vite.org/blog/#electron-vite-5-0-is-out

@wojtekn

wojtekn commented Dec 17, 2025

Copy link
Copy Markdown
Contributor Author

Good catch @fredrikekelund ! I added follow-up: #2274

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants