Update Blueprint details modal styling - #2279
Merged
Merged
Conversation
ivan-ottinger
force-pushed
the
update/blueprint-details-modal-styling
branch
from
December 19, 2025 13:17
edb044c to
5bda72f
Compare
Contributor
📊 Performance Test ResultsComparing cf0a37d vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
gcsecsey
approved these changes
Dec 19, 2025
| name: 'defineSiteUrl', | ||
| reason: __( | ||
| 'Studio manages site URLs internally and cannot accept custom URLs from blueprints' | ||
| 'Studio manages site URLs internally and cannot accept custom URLs from blueprints.' |
Member
There was a problem hiding this comment.
Nit: WDYT about updating this copy to inform the user how they can set the site URL? Eg. Custom site URLs in blueprints are ignored, you can set the site URL on the Settings tab.
Contributor
Author
There was a problem hiding this comment.
Good idea. I have updated the copy in c4d23ec. What do you think about the following?
Custom site URLs in blueprints are ignored. You can set a custom site URL on the Settings tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Related issues
Proposed Changes
Note
Please note that the originally-proposed design (RToz6tIuQ7nlZrikBte4GU-fi-10352_72355) is relying on a custom Calypso
Noticecomponent which isn't available in@wordpress/components. There's a plan to move this custom component into@wordpress/iowhich we can then use in Studio for all the warning notices as well.Because of that, I did not introduce any new custom notice component to Studio. Instead, I adjusted the styling of the Blueprint validation warnings to match the custom
Noticecomponent.Currently proposed changes also use standard WordPress
cautioninstead of a custom one that will come with the newNoticecomponent.Testing Instructions
npm install && npm start.test-multiple-warnings-blueprint.jsonfrom 39ef1-pb/#xml.View detailsbutton and review the new design.Pre-merge Checklist