Skip to content

Update Blueprint details modal styling - #2279

Merged
ivan-ottinger merged 6 commits into
trunkfrom
update/blueprint-details-modal-styling
Dec 19, 2025
Merged

Update Blueprint details modal styling#2279
ivan-ottinger merged 6 commits into
trunkfrom
update/blueprint-details-modal-styling

Conversation

@ivan-ottinger

@ivan-ottinger ivan-ottinger commented Dec 17, 2025

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • update design of the Blueprint details modal
  • add periods to Blueprint validation messages
Before After
CleanShot 2025-12-19 at 15 21 41@2x CleanShot 2025-12-19 at 15 20 04@2x

Note

Please note that the originally-proposed design (RToz6tIuQ7nlZrikBte4GU-fi-10352_72355) is relying on a custom Calypso Notice component which isn't available in @wordpress/components. There's a plan to move this custom component into @wordpress/io which we can then use in Studio for all the warning notices as well.

Because of that, I did not introduce any new custom notice component to Studio. Instead, I adjusted the styling of the Blueprint validation warnings to match the custom Notice component.

Currently proposed changes also use standard WordPress caution instead of a custom one that will come with the new Notice component.

Testing Instructions

  1. Check out the PR branch and build the app with npm install && npm start.
  2. Navigate to Add site → Start from a Blueprint and then select a Blueprint file that has some unsupported steps. For instance, you can pick test-multiple-warnings-blueprint.json from 39ef1-pb/#xml.
  3. Click on the View details button and review the new design.

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@ivan-ottinger ivan-ottinger self-assigned this Dec 17, 2025
@ivan-ottinger
ivan-ottinger force-pushed the update/blueprint-details-modal-styling branch from edb044c to 5bda72f Compare December 19, 2025 13:17
@ivan-ottinger
ivan-ottinger marked this pull request as ready for review December 19, 2025 15:26
@ivan-ottinger
ivan-ottinger requested a review from a team December 19, 2025 15:28
@github-actions

github-actions Bot commented Dec 19, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing cf0a37d vs trunk

site-editor

Metric trunk cf0a37d Diff Change
load 20150.00 ms 15820.00 ms -4330.00 ms 🟢 -21.5%

site-startup

Metric trunk cf0a37d Diff Change
siteCreation 34157.00 ms 30370.00 ms -3787.00 ms 🟢 -11.1%
siteStartup 14158.00 ms 12138.00 ms -2020.00 ms 🟢 -14.3%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the styles @ivan-ottinger! 🙌 These changes LGTM and look much nicer.

Image Image
Comment thread common/lib/blueprint-validation.ts Outdated
name: 'defineSiteUrl',
reason: __(
'Studio manages site URLs internally and cannot accept custom URLs from blueprints'
'Studio manages site URLs internally and cannot accept custom URLs from blueprints.'

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: WDYT about updating this copy to inform the user how they can set the site URL? Eg. Custom site URLs in blueprints are ignored, you can set the site URL on the Settings tab.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. I have updated the copy in c4d23ec. What do you think about the following?

Custom site URLs in blueprints are ignored. You can set a custom site URL on the Settings tab.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect! 🚢

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code LGTM and UI looks nice 👍

Image
@ivan-ottinger
ivan-ottinger merged commit 6e7701c into trunk Dec 19, 2025
11 checks passed
@ivan-ottinger
ivan-ottinger deleted the update/blueprint-details-modal-styling branch December 19, 2025 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants