Skip to content

Studio: Translate "About Studio" modal #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 6 commits into from
Jun 11, 2024
Merged

Studio: Translate "About Studio" modal #228

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
264cc2d
Remove unused script
Jun 10, 2024
8fa1d01
Add and inject translatable strings
Jun 10, 2024
343ac4d
Capture error in Sentry
Jun 11, 2024
4dec4f8
Combine version and version number in one string
Jun 11, 2024
af02dbb
Add sprintif
Jun 11, 2024
6c1f64f
Replace a signle quote
Jun 11, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add sprintif
  • Loading branch information
Kateryna Kodonenko
Kateryna Kodonenko committed Jun 11, 2024
commit af02dbb33cd562e5aa90cddf51fc6864f72e0ace
2 changes: 1 addition & 1 deletion src/about-menu/about-menu.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@
<div>
<img src="./studio-app-icon.png" alt="Studio App Icon" width="64" height="64">
<p class="studio-name" id="studio-by-wpcom">Studio by WordPress.com</p>
<p class="version" id="version-text">Version</p>
<p class="version"><span id="version-text">Version x.y.z</span></p>
<p class="links">
<a href="https://github.com/Automattic/studio" target="_blank">GitHub</a>

@katinthehatsite katinthehatsite Jun 10, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not add translation for GitHub since it is a proper name. Happy to add it if it is considered necessary.
<span class="separator">&middot;</span>
Expand Down
4 changes: 2 additions & 2 deletions src/about-menu/open-about-menu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { BrowserWindow, app, shell } from 'electron';
import path from 'path';
import * as Sentry from '@sentry/electron/renderer';
import { __ } from '@wordpress/i18n';
import { sprintf, __ } from '@wordpress/i18n';
import { ABOUT_WINDOW_HEIGHT, ABOUT_WINDOW_WIDTH } from '../constants';

let aboutWindow: BrowserWindow | null = null;
Expand Down Expand Up @@ -39,7 +39,7 @@ export function openAboutWindow() {

aboutWindow.webContents.on( 'dom-ready', () => {
if ( aboutWindow ) {
const versionText = `${ __( 'Version' ) } ${ packageJson }`;
const versionText = sprintf( __( 'Version %s' ), packageJson );

// Inject version into the about window's HTML
aboutWindow.webContents
Expand Down