Disable add site import from WordPress.com if Studio is offline - #2284
Merged
Conversation
katinthehatsite
approved these changes
Dec 18, 2025
katinthehatsite
left a comment
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
The changes look good and work as expected:
We could potentially improve the offline message with more detail but the current version also works
gcsecsey
approved these changes
Dec 19, 2025
gcsecsey
left a comment
gcsecsey
left a comment
Member
There was a problem hiding this comment.
LGTM and works well, the transition is pretty instantenous after toggling the connection.
CleanShot.2025-12-19.at.15.54.02.mp4
bcotrim
force-pushed
the
add-site-disable-wordpress-if-offline
branch
from
December 19, 2025 16:21
2889a67 to
6fc6fa6
Compare
Contributor
Author
|
@katinthehatsite @gcsecsey thanks for the reviews! |
Contributor
📊 Performance Test ResultsComparing 4a4b7fc vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Testing Instructions
npm startPre-merge Checklist