Skip to content

Fix appearance Query Manager plugin in wp-admin - #2311

Merged
nightnei merged 1 commit into
trunkfrom
fixQueryManagerPlugin
Dec 23, 2025
Merged

Fix appearance Query Manager plugin in wp-admin#2311
nightnei merged 1 commit into
trunkfrom
fixQueryManagerPlugin

Conversation

@nightnei

Copy link
Copy Markdown
Contributor

Proposed Changes

Previously, Query Manager plugin didn't work with Sites that are run under Studio. The reason is - php_sapi_name() return cli. Since it's essential to be "cli" in playground, that's why we needed to go with soem workaround. It would be great to go with some more specific fix as checkoing kinds "is playground-cli", but just for consistency I decided to go with the same fix as applyied for playground. It's a workaround, but actually it's robust.

Testing Instructions

  1. Create Studio site
  2. Open wp-admin
  3. Install "Query Manager" plugin and activate it
  4. Assert that you see it in admin bar (before it wasn't rendered for sites in Studio)
Screenshot 2025-12-23 at 15 14 23 5. Open "Installed plugins" page 6. Assert that you see all buttons
BEFORE AFTER
Screenshot 2025-12-23 at 15 15 58 Screenshot 2025-12-23 at 15 16 08
@nightnei
nightnei requested review from a team and wojtekn December 23, 2025 15:21
@nightnei nightnei self-assigned this Dec 23, 2025
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing a6725c7 vs trunk

site-editor

Metric trunk a6725c7 Diff Change
load 13840.00 ms 21717.00 ms +7877.00 ms 🔴 56.9%

site-startup

Metric trunk a6725c7 Diff Change
siteCreation 21632.00 ms 20803.00 ms -829.00 ms 🟢 -3.8%
siteStartup 8111.00 ms 7023.00 ms -1088.00 ms 🟢 -13.4%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks correct. It is good that we have the same workaround applied in Playground and Studio.

The plugin loads its UI now:

Image

.

@nightnei
nightnei merged commit 5f726cf into trunk Dec 23, 2025
9 checks passed
@nightnei
nightnei deleted the fixQueryManagerPlugin branch December 23, 2025 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants