Skip to content

Studio: Indicate site deletion with loading spinner - #2331

Merged
gavande1 merged 3 commits into
trunkfrom
add/loading-spinner-when-delete-site
Dec 30, 2025
Merged

Studio: Indicate site deletion with loading spinner#2331
gavande1 merged 3 commits into
trunkfrom
add/loading-spinner-when-delete-site

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1179

Proposed Changes

This PR ensures that we display a loading spinner when a site is being deleted to make it consistent with other actions such as site creation:

Screenshot 2025-12-29 at 12 09 50 PM

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • Ensure that you have at least one site
  • Navigate to the Settings tab
  • Click on the ellipsis in the top right corner
  • Click on Delete site
  • Confirm that you can see the spinner while a given site is being deleted
  • Confirm that the spinner does not appear for any other site

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Dec 29, 2025
@katinthehatsite
katinthehatsite requested a review from a team December 29, 2025 11:28
@katinthehatsite katinthehatsite changed the title Add spinner when deleting Dec 29, 2025
@github-actions

github-actions Bot commented Dec 29, 2025

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing f58638e vs trunk

site-editor

Metric trunk f58638e Diff Change
load 10821.00 ms 11255.00 ms +434.00 ms 🔴 4.0%

site-startup

Metric trunk f58638e Diff Change
siteCreation 25633.00 ms 22671.00 ms -2962.00 ms 🟢 -11.6%
siteStartup 10047.00 ms 9075.00 ms -972.00 ms 🟢 -9.7%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and works as expected. LGTM 👍

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works as expected 👍

@gavande1

Copy link
Copy Markdown
Contributor

I restarted the tests

@gavande1
gavande1 merged commit d33e5f1 into trunk Dec 30, 2025
9 checks passed
@gavande1
gavande1 deleted the add/loading-spinner-when-delete-site branch December 30, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants