Skip to content

Studio: SiteForm path does not accommodate long site names - #2333

Merged
gavande1 merged 2 commits into
trunkfrom
fix/cut-off-site-path
Dec 30, 2025
Merged

Studio: SiteForm path does not accommodate long site names#2333
gavande1 merged 2 commits into
trunkfrom
fix/cut-off-site-path

Conversation

@katinthehatsite

Copy link
Copy Markdown
Contributor

Related issues

Fixes STU-1181

Proposed Changes

This PR ensures that when you have a long path name while creating a site, it does not get cut off:

Screenshot 2025-12-29 at 4 24 53 PM

Before

Screenshot 2025-12-29 at 3 58 31 PM

Testing Instructions

  • Pull the changes from this branch
  • Start the app with npm start
  • Click on the Add site option in the sidebar
  • Select the first option
  • Open Advanced settings
  • Change the name of a site to a very long name so that the local path breaks into the second line
  • Observe that the field does not get cut off

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@katinthehatsite katinthehatsite self-assigned this Dec 29, 2025
@katinthehatsite
katinthehatsite requested a review from a team December 29, 2025 15:29
@github-actions

Copy link
Copy Markdown
Contributor

📊 Performance Test Results

Comparing 9413d87 vs trunk

site-editor

Metric trunk 9413d87 Diff Change
load 8168.00 ms 11400.00 ms +3232.00 ms 🔴 39.6%

site-startup

Metric trunk 9413d87 Diff Change
siteCreation 15295.00 ms 15398.00 ms +103.00 ms 🔴 0.7%
siteStartup 6964.00 ms 6969.00 ms +5.00 ms 🔴 0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@gavande1 gavande1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested this and it works great. LGTM 👍

Image
@gavande1

Copy link
Copy Markdown
Contributor

During testing, I noticed unusual behavior where the renderer crashes when the site name is excessively long. I believe this is a separate issue, so I reported it in Linear under STU-1182.

@gavande1
gavande1 merged commit ce7c6f9 into trunk Dec 30, 2025
9 checks passed
@gavande1
gavande1 deleted the fix/cut-off-site-path branch December 30, 2025 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants