Site Creation: Fix renderer crash for long site names when creating new site

[gavande1]

Related issues

• Fixes STU-1182

Proposed Changes

• Added error handling in handleSiteNameChange to catch ENAMETOOLONG errors and display a user-friendly error message when site name is too long
• Added tests to verify ENAMETOOLONG error handling works correctly
• The renderer now gracefully handles long site names instead of crashing

Testing Instructions

1. Open the "Add site" modal
2. Enter a very long site name (e.g., a string of 300+ characters)
3. Verify that instead of crashing, a user-friendly error message is displayed: "The site name is too long. Please choose a shorter site name."
4. Run the test suite: npm test -- src/hooks/tests/use-add-site.test.tsx
5. Verify all tests pass, including the new ENAMETOOLONG error handling tests

Pre-merge Checklist

• Have you checked for TypeScript, React or other console errors?

[wpmobilebot]

📊 Performance Test Results

Comparing 34e6d43 vs trunk

site-editor

Metric	trunk	34e6d43	Diff	Change
load	6317.00 ms	7367.00 ms	+1050.00 ms	🔴 16.6%

site-startup

Metric	trunk	34e6d43	Diff	Change
siteCreation	9070.00 ms	9073.00 ms	+3.00 ms	🔴 0.0%
siteStartup	3951.00 ms	3957.00 ms	+6.00 ms	🔴 0.2%

---

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

[nightnei]

LGTM and works as expected 👍

[wojtekn]

As the exception can be thrown by generateProposedSitePath, it would be clearer to wrap only this part with try/catch.

However, in generateProposedSitePath, we already catch the underlying exception and set returned props accordingly, so we could consider moving exception handling there.

[gavande1]

Initially, My first approach was to handle exceptions in generateProposedSitePath. However, the main issue was with the error message. If we handle the exception in IPC handlers, it prefixes the following error message.

Error invoking remote method 'generateProposedSitePath'

if we want to remove this prefix, I would need to add an additional parameter, such as isError, to indicate that there was a problem. However, I believe this is unnecessary.

[wojtekn]

What if we handled the exception there, returned isNameTooLong prop, and set the error in the renderer process? It would be consistent with current error handling.

[gavande1]

Yes. To make it consistent we can do that. I will update the PR.

[gavande1]

Updated in 34e6d43!

[katinthehatsite]

This looks good to me 👍

I got a visual indication when the site name was too long: