-
Notifications
You must be signed in to change notification settings - Fork 86
Blueprints: Update Blueprint deeplink step design #2397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
a810aef
Remove Blueprint meta default values
ivan-ottinger 238766f
Update Blueprint deeplink step design
ivan-ottinger e63b155
Update Blueprint deeplink title fallback logic
ivan-ottinger 3aa26c8
Update Blueprint deeplink title fallback text
ivan-ottinger f2cc069
Add "Blueprint loaded from URL" footer
ivan-ottinger bece5c6
Update footer padding and alignment
ivan-ottinger 4befcc8
Update Blueprint footer text color
ivan-ottinger 8b40a99
Update Blueprint description text alignment
ivan-ottinger 56e4c99
Update minimum width and alignment
ivan-ottinger 0b50df8
Update container alignment
ivan-ottinger 066dad2
Remove `Blueprint selected` text
ivan-ottinger f35b54f
Update Blueprint deeplink title text alignment and clamping
ivan-ottinger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm unsure if this came up before, but should we filter/sanitize that data?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that in this case a clamp on the length should be enough. I have added it in 2b244d3.
The Blueprint JSON also gets validated before we get title and description out of it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, React escapes any tags included in those, but we could consider some sanitization, too.