Increase metrics test timeouts and retries for CI reliability - #2408
Closed
iangmaia wants to merge 5 commits into
Closed
Increase metrics test timeouts and retries for CI reliability#2408iangmaia wants to merge 5 commits into
iangmaia wants to merge 5 commits into
Conversation
The metrics test consistently fails on CI due to slow site creation. Analysis of recent trunk builds shows this is infrastructure variability, not a code bug. Increasing timeouts from 120s to 180s and retries from 1 to 2 should handle the occasional slow CI runs. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add debugLog helper function for timestamped logging - Capture screenshots on failure at critical points (onboarding, site content) - Increase timeouts by 50% for CI stability: - Global test timeout: 180s → 270s - Action timeout: 60s → 90s - Expect timeout: 30s → 45s - Iframe wait: 120s → 180s - Block selector wait: 60s → 90s - Onboarding/site content waits: 180s → 270s This addresses intermittent CI failures where the app startup or site creation takes longer than expected on some CI runners. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Enable 'only-on-failure' screenshots in Playwright config - Add waitForWithScreenshots() helper that takes screenshots every 30s while waiting for site content heading - Add *.png to metrics artifact paths to upload screenshots - This will help diagnose what's on screen during the ~4 minute hang Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Write screenshots as actual PNG files to ARTIFACTS_PATH - Reduce effective timeout to 240s to avoid race with test timeout - Log screenshot file paths for easier debugging - This ensures screenshots get uploaded as build artifacts Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
iangmaia
force-pushed
the
iangmaia/increase-metrics-timeout
branch
from
January 16, 2026 15:18
5fe1cf0 to
67d9da5
Compare
Collaborator
📊 Performance Test ResultsComparing 67d9da5 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes AINFRA-1760
Summary
A few more changes after seeing performance metrics failing once again after #2407 got merged to trunk: https://buildkite.com/automattic/studio/builds/10600.
The metrics test (
site-editor.test.ts) has been consistently failing on trunk builds due to slow site creation on CI infrastructure:Changes
Increased timeouts from 120s to 180s for slow operations:
Increased retries from 1 to 2 in metrics playwright config to handle CI infrastructure variability
Test Plan
🤖 Generated with Claude Code