Skip to content

Avoid removing an error check in the @php-wasm/node patch - #2416

Merged
wojtekn merged 1 commit into
trunkfrom
fix/add-php-version-error
Jan 20, 2026
Merged

Avoid removing an error check in the @php-wasm/node patch#2416
wojtekn merged 1 commit into
trunkfrom
fix/add-php-version-error

Conversation

@epeicher

@epeicher epeicher commented Jan 19, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Add back an exception removed by the patch by mistake

Testing Instructions

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing e1b3284 vs trunk

site-editor

Metric trunk e1b3284 Diff Change
load 2920.00 ms 2945.00 ms +25.00 ms 🔴 0.9%

site-startup

Metric trunk e1b3284 Diff Change
siteCreation 8075.00 ms 7111.00 ms -964.00 ms 🟢 -11.9%
siteStartup 3953.00 ms 3953.00 ms 0.00 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@sejas sejas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for restoring the throw error. 👍

@wojtekn
wojtekn merged commit 0c107dd into trunk Jan 20, 2026
12 checks passed
@wojtekn
wojtekn deleted the fix/add-php-version-error branch January 20, 2026 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants