Skip to content

Fix layout shifts after selecting custom Blueprint - #2425

Merged
bcotrim merged 2 commits into
trunkfrom
stu-1219-layout-shifts-custom-blueprint
Jan 21, 2026
Merged

Fix layout shifts after selecting custom Blueprint#2425
bcotrim merged 2 commits into
trunkfrom
stu-1219-layout-shifts-custom-blueprint

Conversation

@bcotrim

@bcotrim bcotrim commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • Add fixed height (h-7) to the HStack containing "Featured Blueprints" text and the Blueprint file selector
  • This prevents layout shifts when toggling between the "Choose Blueprint file" button and the selected file name with "Remove" button

Testing Instructions

  1. Start Studio
  2. Click "Add site" → "Start from a Blueprint"
  3. Click "Choose Blueprint file" and select a valid Blueprint JSON file
  4. Verify no layout shift occurs when the file is selected
  5. Click "Remove" to clear the selection
  6. Verify no layout shift occurs when returning to the upload button state
  7. Repeat selection/removal a few times to confirm stability

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@bcotrim bcotrim self-assigned this Jan 20, 2026
@bcotrim
bcotrim requested a review from a team January 20, 2026 11:06

@epeicher epeicher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bcotrim! I have tested it, and I can confirm that I don't see the layout shift anymore when adding or removing blueprints. LGTM! :shipit:

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, I did not notice any more layout shifts.

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing daaa39b vs trunk

site-editor

Metric trunk daaa39b Diff Change
load 2858.00 ms 2864.00 ms +6.00 ms 🔴 0.2%

site-startup

Metric trunk daaa39b Diff Change
siteCreation 8079.00 ms 7090.00 ms -989.00 ms 🟢 -12.2%
siteStartup 3943.00 ms 3940.00 ms -3.00 ms 🟢 -0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@bcotrim
bcotrim merged commit abab3ea into trunk Jan 21, 2026
9 checks passed
@bcotrim
bcotrim deleted the stu-1219-layout-shifts-custom-blueprint branch January 21, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants