Skip to content

Fix Blueprint version warning not displaying immediately - #2430

Merged
wojtekn merged 10 commits into
trunkfrom
STU-1218/blueprint-version-warning-immediate-display
Jan 21, 2026
Merged

Fix Blueprint version warning not displaying immediately#2430
wojtekn merged 10 commits into
trunkfrom
STU-1218/blueprint-version-warning-immediate-display

Conversation

@sejas

@sejas sejas commented Jan 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related issues

Issue

When creating a site from a Blueprint with specific PHP/WP version requirements, the version mismatch warning only appeared after manually changing the version dropdowns - not immediately when the Blueprint was selected.

Proposed Changes

  • Display the label 1 warning found when PHP or WordPress versions are not supported.
  • Display the full warning when the Blueprint PHP or WP version is not supported, without requiring the user to change the dropdown to appear the warning.
Screenshot 2026-01-20 at 15 46 31

Testing Instructions

  1. Start Studio by running npm start and click "Add site"
  2. Choose "Start from a Blueprint"
  3. Select a Blueprint that specifies PHP 7.0 (or any non supported version) like blueprint-unsupported-php.json
  4. Click "Continue"
  5. Expected: See "1 warning found" in amber next to "Advanced settings"
  6. Open "Advanced settings"
  7. Confirm you see a warning notice appears immediately showing Blueprint's version requirements
  8. Before fix: Warning only appeared after manually changing the PHP version dropdown
php-wp-version-warning.mp4

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
sejas added 6 commits January 20, 2026 13:54
@sejas
Fix Blueprint version warning not displaying immediately (#STU-1218)
198a4d4 
The warning now compares Blueprint versions against original defaults
instead of current form values, ensuring it shows right away when
a Blueprint with different versions is selected.
@sejas
Show warning indicator next to Advanced settings button
f6d0e02 
Displays "1 warning found" in amber when a Blueprint specifies
version requirements different from defaults, matching the
existing error indicator behavior.
@sejas
Simplify warning conditions
952150b
@sejas
Validate Blueprint PHP version before applying to dropdown
77d84f4 
Prevents the PHP dropdown from showing an incorrect value when a
Blueprint specifies an unsupported PHP version (e.g., 7.0). Now only
applies the Blueprint version if it's in the SupportedPHPVersionsList.
@sejas
Restore copies
361ea21
@sejas
Update tests
0606b72
@sejas sejas self-assigned this Jan 20, 2026
@sejas
sejas requested a review from a team January 20, 2026 20:53
@sejas
sejas marked this pull request as ready for review January 20, 2026 20:54
gavande1
gavande1 approved these changes Jan 21, 2026
View reviewed changes

@gavande1 gavande1 left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tested this, and it works as described. LGMT 👍 Only minor comment about spacing between "This blueprint recommends" and "Using different versions...", there seems to be uneven spacing. It doesn't look good or polished.

CleanShot 2026-01-21 at 14 37 44@2x
Image
wojtekn
wojtekn reviewed Jan 21, 2026
View reviewed changes

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works correctly now - I see the warning icon right away, even without expanding the Advanced settings.
@wpmobilebot

wpmobilebot commented Jan 21, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 8169a9a vs trunk

site-editor

Metric trunk 8169a9a Diff Change
load 2843.00 ms 2896.00 ms +53.00 ms 🔴 1.9%

site-startup

Metric trunk 8169a9a Diff Change
siteCreation 7085.00 ms 7092.00 ms +7.00 ms 🔴 0.1%
siteStartup 3950.00 ms 3946.00 ms -4.00 ms 🟢 -0.1%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change
@wojtekn
wojtekn merged commit 38e8078 into trunk Jan 21, 2026
10 checks passed
@wojtekn
wojtekn deleted the STU-1218/blueprint-version-warning-immediate-display branch January 21, 2026 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewer can merge

4 participants

@sejas @wpmobilebot @wojtekn @gavande1