Update site selection behavior after site deletion - #2459
Merged
gcsecsey merged 2 commits intoJan 23, 2026
Merged
Conversation
- Update site selection logic to preserve the currently selected site if it still exists after deletion. - Add tests to verify that the first remaining site is selected when the currently selected site is deleted, and that selection remains unchanged when a different site is deleted.
Collaborator
📊 Performance Test ResultsComparing 17075a3 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
ivan-ottinger
approved these changes
Jan 22, 2026
ivan-ottinger
left a comment
Contributor
There was a problem hiding this comment.
Nice! Works well and the change looks good. Thank you for adding the test as well.
CleanShot.2026-01-22.at.15.38.30.mp4
…ves-to-the-first-site
gcsecsey
deleted the
stu-1241-when-deleting-site-focus-always-moves-to-the-first-site
branch
January 23, 2026 09:55
Contributor
|
It seems it still changes the tab to Overview for the selected site. |
1 task
Member
Author
Good catch, I added a follow-up for this in #2468 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Related issues
Proposed Changes
onDeleteSiteto check if the currently selected site still exists after deletionTesting Instructions
npm startPre-merge Checklist