Fix bundled node permissions - #2473
Merged
bcotrim merged 3 commits intoJan 26, 2026
Merged
Conversation
fredrikekelund
approved these changes
Jan 26, 2026
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
I confirm that this fixes the issue: the bundled node runtime now spawns as expected in the macOS Intel build.
…hes-on-intel-macs-macos-13
bcotrim
marked this pull request as ready for review
January 26, 2026 11:06
Collaborator
📊 Performance Test ResultsComparing b920a90 vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
bcotrim
deleted the
stu-1253-bug-report-trace-trap-sigtrap-crashes-on-intel-macs-macos-13
branch
January 26, 2026 11:38
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
Root Cause
When electron-forge signs the app, it re-signs the bundled Node binary with Electron's default entitlements. These entitlements are missing critical permissions that Node.js/V8 requires for JIT compilation:
cs.allow-jitcs.allow-unsigned-executable-memorycs.disable-executable-page-protectioncs.disable-library-validationWithout these entitlements, V8's baseline compiler crashes when trying to allocate executable memory:
The Fix
entitlements/node.plistwith the required V8/JIT entitlementsforge.config.tsto useoptionsForFileto apply these entitlements specifically tobin/nodeduring code signingTesting Instructions
To verify the fix is applied:
Should show:
com.apple.security.cs.allow-jitcom.apple.security.cs.allow-unsigned-executable-memorycom.apple.security.cs.disable-executable-page-protectioncom.apple.security.cs.disable-library-validationPre-merge Checklist