Remove Xdebug from Beta Features menu - #2523
Conversation
📊 Performance Test ResultsComparing 749611a vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change |
bcotrim
left a comment
There was a problem hiding this comment.
Nice cleanup! 🙌 The feature flag removal looks good!
There are a couple of issues:
- Test failure: Missing mock in
edit-site-details.test.tsx
Tests are failing with .getXdebugEnabledSite is not a function.
Previously, the getXdebugEnabledSite() call was guarded by if (isXdebugFeatureEnabled), so the mock wasn’t needed. Now that the conditional is removed, the function is always called. For fix we should add the mock to src/modules/site-settings/tests/edit-site-details.test.tsx.
- Formatting issue in
edit-site-details.tsx
|
|
||
| consoleSpy.mockRestore(); | ||
| } ); | ||
|
|
There was a problem hiding this comment.
This seems like an unintended change
There was a problem hiding this comment.
It was a fix for the linter finding.
katinthehatsite
left a comment
There was a problem hiding this comment.
I re-tested everything once again just in case, and it worked as expected 👍
|
Hello, Do we have instructions how to Activate XDebug? I don't see very clear... |
Hi @davidperezgar here are the instructions for using xdebug in Studio: |
|
Thanks! |
Related issues
Proposed Changes
Testing Instructions
Pre-merge Checklist