Skip to content

Remove Xdebug from Beta Features menu - #2523

Merged
wojtekn merged 3 commits into
trunkfrom
remove/xdebug-feature-flag
Feb 4, 2026
Merged

Remove Xdebug from Beta Features menu#2523
wojtekn merged 3 commits into
trunkfrom
remove/xdebug-feature-flag

Conversation

@wojtekn

@wojtekn wojtekn commented Feb 3, 2026

Copy link
Copy Markdown
Contributor

Related issues

Proposed Changes

  • I propose removing Xdebug from Beta Features menu, to enable it for all users.

Testing Instructions

  • Confirm, if Xdebug flows work, both in UI and CLI

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@wojtekn wojtekn self-assigned this Feb 3, 2026
@wojtekn
wojtekn requested a review from a team February 3, 2026 14:23
@wpmobilebot

wpmobilebot commented Feb 3, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 749611a vs trunk

site-editor

Metric trunk 749611a Diff Change
load 2902.00 ms 2916.00 ms +14.00 ms 🔴 0.5%

site-startup

Metric trunk 749611a Diff Change
siteCreation 7086.00 ms 7109.00 ms +23.00 ms 🔴 0.3%
siteStartup 3917.00 ms 3924.00 ms +7.00 ms 🔴 0.2%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change

@bcotrim bcotrim left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup! 🙌 The feature flag removal looks good!

There are a couple of issues:

  1. Test failure: Missing mock in edit-site-details.test.tsx

Tests are failing with .getXdebugEnabledSite is not a function.

Previously, the getXdebugEnabledSite() call was guarded by if (isXdebugFeatureEnabled), so the mock wasn’t needed. Now that the conditional is removed, the function is always called. For fix we should add the mock to src/modules/site-settings/tests/edit-site-details.test.tsx.

  1. Formatting issue in edit-site-details.tsx

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes work as expected 👍 (aside from the issues Bernardo mentioned)


consoleSpy.mockRestore();
} );

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like an unintended change

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was a fix for the linter finding.

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I re-tested everything once again just in case, and it worked as expected 👍

@wojtekn
wojtekn merged commit eda0284 into trunk Feb 4, 2026
11 checks passed
@wojtekn
wojtekn deleted the remove/xdebug-feature-flag branch February 4, 2026 10:36
@davidperezgar

Copy link
Copy Markdown

Hello, Do we have instructions how to Activate XDebug? I don't see very clear...

@bcotrim

bcotrim commented Feb 17, 2026

Copy link
Copy Markdown
Contributor

Hello, Do we have instructions how to Activate XDebug? I don't see very clear...

Hi @davidperezgar here are the instructions for using xdebug in Studio:
https://developer.wordpress.com/docs/developer-tools/studio/xdebug/

@davidperezgar

Copy link
Copy Markdown

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants