Fix Studio CLI yargs locale strings displaying in English - #2609
Merged
Conversation
Import yargs locale files directly to bypass y18n's broken path resolution after bundling. Use updateLocale() to apply inline locale data.
epeicher
approved these changes
Feb 19, 2026
Contributor
There was a problem hiding this comment.
Are these changes required?
Collaborator
📊 Performance Test ResultsComparing e59088d vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Contributor
@bcotrim, how is it broken? It's nice to fix the problem, but this seems like something that should ideally be a temporary workaround until y18n is fixed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Related issues
Proposed Changes
yargs.updateLocale()to apply inline locale data instead of relying on filesystem-based locale loadinguk->uk_UAlocale mapping inmapToYargsLocale()loadTranslations()for yargs to useTesting Instructions
Set a non-English locale in Studio UI and run
studio --help:Portuguese (Brazil):
Verify "Comandos:", "Opções:", "Exibe ajuda" appear (not "Commands:", "Options:", "Show help")
Ukrainian:
Verify "Команди:", "Опції:", "Показати довідку" appear
Chinese (Simplified):
Verify Chinese characters appear for yargs strings
English:
Verify fallback to English still works correctly.
Pre-merge Checklist