Fix push cancellation error dialog - #2633
Merged
epeicher merged 1 commit intoFeb 23, 2026
Merged
Conversation
…efully Electron IPC wraps error messages as "Error invoking remote method '...': Error: <message>", so the strict equality check `=== 'Export aborted'` never matched. Use `.includes()` instead, consistent with other IPC error checks in the codebase.
Collaborator
📊 Performance Test ResultsComparing a17aa0b vs trunk site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
bcotrim
approved these changes
Feb 20, 2026
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Works as described
LGTM 👍
katinthehatsite
approved these changes
Feb 23, 2026
katinthehatsite
left a comment
Contributor
There was a problem hiding this comment.
This worked as expected for me 👍
epeicher
deleted the
stu-1087-cancelling-a-push-operation-returns-an-error
branch
February 23, 2026 10:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
Proposed Changes
.includes('Export aborted')instead of=== 'Export aborted'when checking for push cancellation errors in the renderer process."Error invoking remote method '...': Error: <message>", so the strict equality check never matched the wrapped message. This caused cancelling a push during the export phase to show an error dialog and report to Sentry, instead of gracefully handling the cancellation.use-site-details.tsxuses.includes()for the same reason).Testing Instructions
Pre-merge Checklist