Skip to content

Include AI acknowledgement in GitHub PR template - #2691

Merged
fredrikekelund merged 1 commit into
trunkfrom
f26d/github-pr-template-ai-acknowledgement
Mar 3, 2026
Merged

Include AI acknowledgement in GitHub PR template#2691
fredrikekelund merged 1 commit into
trunkfrom
f26d/github-pr-template-ai-acknowledgement

Conversation

@fredrikekelund

Copy link
Copy Markdown
Contributor

Related issues

See pesfPa-1Nc-p2

Proposed Changes

Update the GitHub PR template to include a "How AI was used in this PR" section. This is a completely free-form section, aimed at helping code reviewers understand how to approach the PR. It's also a good place to acknowledge that you've reviewed the code, or that it's more of a vibe-coded PR.

See #2690 for an example of how we might use this section.

Testing Instructions

N/A

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@fredrikekelund
fredrikekelund requested a review from a team March 3, 2026 10:00
@fredrikekelund fredrikekelund self-assigned this Mar 3, 2026

@nightnei nightnei left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@@ -1,13 +1,21 @@
## Related issues

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katinthehatsite

Copy link
Copy Markdown
Contributor

It's also a good place to acknowledge that you've reviewed the code, or that it's more of a vibe-coded PR.

I thought we are supposed to review everything in our own PRs 🙈

@katinthehatsite katinthehatsite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good 👍

@wojtekn

wojtekn commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

I thought we are supposed to review everything in our own PRs 🙈

Ideally, we do. I understand the intention to let author confirm one of the following:

  • I wrote the PR myself
  • I used AI to create PR, but reviewed it thoroughly, and I'm confident about the code
  • I used AI to create PR, but haven't reviewed it much
  • I used AI to create PR, but I don't fully understand the code
  • etc.
@fredrikekelund

Copy link
Copy Markdown
Contributor Author

I thought we are supposed to review everything in our own PRs 🙈

What @wojtekn said 🙂

We are indeed supposed to do that, but the reality is that it varies based on several factors (many of which are completely legitimate, even if laziness probably also sneaks in on occasion).

Aside from helping reviewers, I think this will also help PR authors pause and reflect before submitting the PR: Did I really review all of the code? Have I actually looked at the test implementation? Am I confident about the root cause of the bug I'm fixing?

Lastly, it'll be helpful for fully vibe-coded PRs. We already know when PRs are vibe-coded, but it should be clearly acknowledged.

@fredrikekelund
fredrikekelund merged commit 98d9d62 into trunk Mar 3, 2026
11 checks passed
@fredrikekelund
fredrikekelund deleted the f26d/github-pr-template-ai-acknowledgement branch March 3, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants