Use the OS native dialog to confirm a site deletion - #27
Merged
Conversation
Contributor
|
Looks good and works as expected. Thanks @jeroenpf! 
|
SiobhyB
self-requested a review
April 25, 2024 21:43
SiobhyB
approved these changes
Apr 25, 2024
SiobhyB
left a comment
SiobhyB
left a comment
There was a problem hiding this comment.
I've added a couple of comments around error handling for your consideration, but the overall flow works as expected for me!
| setNeedsConfirmation( false ); | ||
| await deleteSite( selectedSite.id, checkboxChecked ); | ||
| } catch ( e ) { | ||
| /* empty */ |
There was a problem hiding this comment.
Should we display an error message if deletion fails? We could use a similar error to this one we display when updating a site fails.
Contributor
Author
There was a problem hiding this comment.
Thanks for the review! I've added error handling as per your suggestion.
|
|
||
| const DeleteSite = () => { | ||
| const { __ } = useI18n(); | ||
| const { selectedSite, deleteSite, isDeleting, deleteError } = useSiteDetails(); |
There was a problem hiding this comment.
As deleteError isn't used anywhere else, can it be removed from the useSiteDetails hook?
Contributor
Author
There was a problem hiding this comment.
I've deleted it now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to https://github.com/Automattic/dotcom-forge/issues/6672
Proposed Changes
onDeleteSitewhere whennewSitesis empty, we try to access index 0 which causes an error.Testing Instructions
Pre-merge Checklist