Refactor E2E tests initialization - #270
Merged
Merged
Conversation
This class will simplify running tests by isolating the data generated in an E2E session.
fluiddot
force-pushed
the
update/refactor-e2e-tests-initialization
branch
from
June 18, 2024 18:07
8a9a4f5 to
3f7758f
Compare
dcalhoun
approved these changes
Jun 19, 2024
dcalhoun
left a comment
dcalhoun
left a comment
Member
There was a problem hiding this comment.
A great improvement for test stability. Well done! 👏🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #258, as it can help address some issues spotted on Windows.
Proposed Changes
Testing Instructions
CI
Local
npm run package.npm run e2e.Pre-merge Checklist