Remove AllowedPHPVersion type - #2720
Merged
fredrikekelund merged 5 commits intoMar 11, 2026
Merged
Conversation
bcotrim
approved these changes
Mar 6, 2026
bcotrim
left a comment
bcotrim
left a comment
Contributor
There was a problem hiding this comment.
Good cleanup 👍
We could probably remove the provider constants slice now, but I would consider a good follow-up PR. Let me know if you want me to take care of that.
I did not notice any regressions when testing the app, PHP versions behave as expected when creating/editing sites.
Contributor
Author
1 task
…allowed-php-version-type
fredrikekelund
merged commit Mar 11, 2026
7f91189
into
f26d/fix-some-unsafe-type-assertions
3 of 5 checks passed
fredrikekelund
added a commit
that referenced
this pull request
Mar 11, 2026
* Fix some unsafe type assertions * More fixes * Cleanup * Typo * Narrow type * Fix tests * Fix more types * Change import * Inline `isStepDefinition` function * Fix type errors * Address review feedback * Remove `AllowedPHPVersion` type (#2720) * Remove `AllowedPHPVersion` type * Remove unused `setProviderConstants` action * Fix type error * Fix test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
N/A
How AI was used in this PR
Barely at all. I identified the underlying problem and fixed it by hand.
Proposed Changes
Note
This PR builds upon the changes in #2719.
The
AllowedPHPVersiontype is misleading. It's just astringtype, butSupportedPHPVersionis really our canonical definition of which PHP versions we support. This PR removesAllowedPHPVersionand replaces it withSupportedPHPVersion.I also took the opportunity to remove
apps/studio/src/lib/wordpress-server-types.tsin its entirety, since the only other definition there was theWordPressServerProcessinterface. We only have a single implementation of that interface now, so I think it makes more sense to remove it.Tagging @bcotrim for review, since
wordpress-server-types.tswas originally implemented in #2281.Testing Instructions
Code review should suffice
Pre-merge Checklist