Skip to content

Update Studio CLI settings toggle copy and layout - #2855

Merged
shaunandrews merged 3 commits into
trunkfrom
update-cli-settings-ui
Mar 24, 2026
Merged

Update Studio CLI settings toggle copy and layout#2855
shaunandrews merged 3 commits into
trunkfrom
update-cli-settings-ui

Conversation

@shaunandrews

@shaunandrews shaunandrews commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

Before:

image

After:
image

Proposed Changes

  • Rename "Studio CLI" to "Studio CLI for terminal" with bold inline label
  • Replace technical enable/disable copy with a description of what the CLI does: manage sites, run WP-CLI commands, and control local environment
  • Style the studio command in a <code> tag
  • Unify mac/Windows copy into a single description
  • Fix Learn More link color in dark mode

Testing Instructions

  1. npm start
  2. Open Settings > Preferences
  3. Verify the Studio CLI toggle shows the new copy and layout

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@wpmobilebot

wpmobilebot commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing a8d724a vs trunk

app-size

Metric trunk a8d724a Diff Change
App Size (Mac) 1237.45 MB 1237.45 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk a8d724a Diff Change
load 1977 ms 1938 ms 39 ms ⚪ 0.0%

site-startup

Metric trunk a8d724a Diff Change
siteCreation 7096 ms 6102 ms 994 ms 🟢 -14.0%
siteStartup 3934 ms 3944 ms +10 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@wojtekn

wojtekn commented Mar 20, 2026

Copy link
Copy Markdown
Contributor

I rerun tests.

@wojtekn

wojtekn commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@shaunandrews I fixed the test and merged the trunk to this branch.

@wojtekn

wojtekn commented Mar 23, 2026

Copy link
Copy Markdown
Contributor

@shaunandrews, the field looks cleaner now.

Did you consider placing the description below, to make it consistent with other fields?

CleanShot 2026-03-23 at 16 39 03@2x
@katinthehatsite

Copy link
Copy Markdown
Contributor

Did you consider placing the description below, to make it consistent with other fields?

I had the same idea while reviewing this PR. I think it looks slightly disproportionate at the moment and this proposal makes it slightly better aligned.

@shaunandrews

Copy link
Copy Markdown
Contributor Author

I generally prefer toggles on the right, for this very reason. However, the WordPress design system is pretty clear that toggles go on the left, and the help text is indented. In some way, I think its intended to act like a bullet point list.

image

@wojtekn wojtekn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for sharing the context @shaunandrews .

It probably looks a little odd because the description is long. It will look better when we increase the size of the settings dialog.

@shaunandrews
shaunandrews merged commit 9c34372 into trunk Mar 24, 2026
11 checks passed
@shaunandrews
shaunandrews deleted the update-cli-settings-ui branch March 24, 2026 17:21
fredrikekelund pushed a commit that referenced this pull request Mar 24, 2026
* Update Studio CLI toggle copy and layout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix unit tests to follow UI change

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
fredrikekelund added a commit that referenced this pull request Mar 24, 2026
* [skip ci] Code freeze: Update translatable strings for 1.7.7

* [skip ci] Code freeze: Add draft release notes for 1.7.7

* Fix Prettier lint error in ipc-handlers import statement (#2893)

* Update Studio CLI settings toggle copy and layout (#2855)

* Update Studio CLI toggle copy and layout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix unit tests to follow UI change

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>

* Studio: Borders don't have correct colors in dark mode (#2885)

* Add rule for buttons borders

* Improve comment

---------

Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta1

* Update CLI version

* Preliminary release notes cleanup

---------

Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>
fredrikekelund added a commit that referenced this pull request Mar 26, 2026
* [skip ci] Code freeze: Update translatable strings for 1.7.7

* [skip ci] Code freeze: Add draft release notes for 1.7.7

* Fix Prettier lint error in ipc-handlers import statement (#2893)

* Update Studio CLI settings toggle copy and layout (#2855)

* Update Studio CLI toggle copy and layout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix unit tests to follow UI change

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>

* Studio: Borders don't have correct colors in dark mode (#2885)

* Add rule for buttons borders

* Improve comment

---------

Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta1

* Update CLI version

* Preliminary release notes cleanup

* Fix: CLI doesn't generate site thumbnails (#2850)

* Consolidate thumbnail capture to shared CLI path

Create a single thumbnail capture path through captureSiteThumbnail() that is used by both the desktop UI (loadThemeDetails) and CLI events subscriber. This eliminates duplication and uses pendingCaptures deduplication to prevent concurrent BrowserWindow creation when the same site is captured by multiple paths simultaneously.

* remove comments

* Use sequential util with deduplicateKey for thumbnail capture

* Fix E2E copy-site test targeting wrong BrowserWindow

The thumbnail capture feature creates hidden BrowserWindows for
screenshots. The copy-site test used getAllWindows()[0] to send
the IPC event, which could target the screenshot window instead
of the main app window, causing the copy action to silently fail.
Use getFocusedWindow() with a visible-window fallback instead.

---------

Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>

* Disable Redis/memcached when JSPI is unavailable (#2900)

* Disable Redis and memcached PHP extensions when JSPI is unavailable

These extensions require JSPI (JavaScript Promise Integration), which is
only available in Node.js 24+. On Node <24, enabling them crashes the
WordPress server at startup. This conditionally disables them when JSPI
isn't available, matching the pattern in process-manager-daemon.ts.

Also bumps the minimum engine version to >=24.0.0 since the production
build strips asyncify binaries, making Node 24+ a de facto requirement.

* Revert engine version bump to >=22.0.0

* Sort sites by sortOrder when loading from IPC (#2902)

* Fix regressions around deleting preview sites (#2903)

* Support deleting all preview sites from CLI and app

* Update tests

* Fix

* Improve schemas and types

* Tweak

* Fix JSPI detection using runtime feature check (#2906)

* Fix JSPI detection using runtime feature check instead of Node version

Replace semver.gte(process.version, '24.0.0') with a runtime check for
WebAssembly.promising to detect JSPI availability. The version check
assumed Node 24+ has JSPI enabled by default, but it requires the
--experimental-wasm-jspi flag. This caused "Redis extension requires
JSPI" errors when running CLI commands directly without the flag.

Extract the check into a shared isJspiAvailable helper in
tools/common/lib/jspi.ts so there is a single source of truth.

* Remove unverified claim about JSPI proposal stage from comment

* Fix linting

* Address review suggestions

* Pass `--experimental-wasm-jspi` to node in bin script

---------

Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta2

* Minuscule CLI README tweak (#2917)

* Minuscule CLI README tweak

* Fix tests

* Address review comments

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json` (#2916)

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json`

* Fix tests

* Fix tests

* Fix tests

* Fix What's New current step icon color in dark mode (#2921)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Update release notes for 1.7.7 (#2905)

* Update release notes for 1.7.7

* Address review suggestions

* Ensure that language packs are bundled in `wp-files` (#2922)

* Add phpMyAdmin to What's New dialog (#2920)

* Add phpMyAdmin to What's New dialog

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Improve wording

* Force What's New for next version

* Update phpMyAdmin illustration with dot grid background

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>

* Refactor and clean up site deletion logic in app (#2915)

* Refactor site deletion in app

* Nit fix

* [skip ci] Bump version to 1.7.7-beta3

---------

Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>
Co-authored-by: Gergely Csécsey <gergely.csecsey@automattic.com>
Co-authored-by: Ivan Ottinger <ivan.ottinger@automattic.com>
Co-authored-by: Bernardo Cotrim <bmmcotrim@gmail.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com>
Co-authored-by: Wojtek Naruniec <wojtek.naruniec@automattic.com>
fredrikekelund added a commit that referenced this pull request Mar 27, 2026
* [skip ci] Code freeze: Update translatable strings for 1.7.7

* [skip ci] Code freeze: Add draft release notes for 1.7.7

* Fix Prettier lint error in ipc-handlers import statement (#2893)

* Update Studio CLI settings toggle copy and layout (#2855)

* Update Studio CLI toggle copy and layout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix unit tests to follow UI change

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>

* Studio: Borders don't have correct colors in dark mode (#2885)

* Add rule for buttons borders

* Improve comment

---------

Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta1

* Update CLI version

* Preliminary release notes cleanup

* Fix: CLI doesn't generate site thumbnails (#2850)

* Consolidate thumbnail capture to shared CLI path

Create a single thumbnail capture path through captureSiteThumbnail() that is used by both the desktop UI (loadThemeDetails) and CLI events subscriber. This eliminates duplication and uses pendingCaptures deduplication to prevent concurrent BrowserWindow creation when the same site is captured by multiple paths simultaneously.

* remove comments

* Use sequential util with deduplicateKey for thumbnail capture

* Fix E2E copy-site test targeting wrong BrowserWindow

The thumbnail capture feature creates hidden BrowserWindows for
screenshots. The copy-site test used getAllWindows()[0] to send
the IPC event, which could target the screenshot window instead
of the main app window, causing the copy action to silently fail.
Use getFocusedWindow() with a visible-window fallback instead.

---------

Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>

* Disable Redis/memcached when JSPI is unavailable (#2900)

* Disable Redis and memcached PHP extensions when JSPI is unavailable

These extensions require JSPI (JavaScript Promise Integration), which is
only available in Node.js 24+. On Node <24, enabling them crashes the
WordPress server at startup. This conditionally disables them when JSPI
isn't available, matching the pattern in process-manager-daemon.ts.

Also bumps the minimum engine version to >=24.0.0 since the production
build strips asyncify binaries, making Node 24+ a de facto requirement.

* Revert engine version bump to >=22.0.0

* Sort sites by sortOrder when loading from IPC (#2902)

* Fix regressions around deleting preview sites (#2903)

* Support deleting all preview sites from CLI and app

* Update tests

* Fix

* Improve schemas and types

* Tweak

* Fix JSPI detection using runtime feature check (#2906)

* Fix JSPI detection using runtime feature check instead of Node version

Replace semver.gte(process.version, '24.0.0') with a runtime check for
WebAssembly.promising to detect JSPI availability. The version check
assumed Node 24+ has JSPI enabled by default, but it requires the
--experimental-wasm-jspi flag. This caused "Redis extension requires
JSPI" errors when running CLI commands directly without the flag.

Extract the check into a shared isJspiAvailable helper in
tools/common/lib/jspi.ts so there is a single source of truth.

* Remove unverified claim about JSPI proposal stage from comment

* Fix linting

* Address review suggestions

* Pass `--experimental-wasm-jspi` to node in bin script

---------

Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta2

* Minuscule CLI README tweak (#2917)

* Minuscule CLI README tweak

* Fix tests

* Address review comments

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json` (#2916)

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json`

* Fix tests

* Fix tests

* Fix tests

* Fix What's New current step icon color in dark mode (#2921)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Update release notes for 1.7.7 (#2905)

* Update release notes for 1.7.7

* Address review suggestions

* Ensure that language packs are bundled in `wp-files` (#2922)

* Add phpMyAdmin to What's New dialog (#2920)

* Add phpMyAdmin to What's New dialog

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Improve wording

* Force What's New for next version

* Update phpMyAdmin illustration with dot grid background

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>

* Refactor and clean up site deletion logic in app (#2915)

* Refactor site deletion in app

* Nit fix

* [skip ci] Bump version to 1.7.7-beta3

* Emit `deleted` site event when removing empty site (#2929)

* Bump CLI version

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7

* [skip ci] Bump CLI version to 1.7.7

---------

Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>
Co-authored-by: Gergely Csécsey <gergely.csecsey@automattic.com>
Co-authored-by: Ivan Ottinger <ivan.ottinger@automattic.com>
Co-authored-by: Bernardo Cotrim <bmmcotrim@gmail.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com>
Co-authored-by: Wojtek Naruniec <wojtek.naruniec@automattic.com>
fredrikekelund added a commit that referenced this pull request Apr 2, 2026
* [skip ci] Code freeze: Update translatable strings for 1.7.7

* [skip ci] Code freeze: Add draft release notes for 1.7.7

* Fix Prettier lint error in ipc-handlers import statement (#2893)

* Update Studio CLI settings toggle copy and layout (#2855)

* Update Studio CLI toggle copy and layout

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Fix unit tests to follow UI change

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>

* Studio: Borders don't have correct colors in dark mode (#2885)

* Add rule for buttons borders

* Improve comment

---------

Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta1

* Update CLI version

* Preliminary release notes cleanup

* Fix: CLI doesn't generate site thumbnails (#2850)

* Consolidate thumbnail capture to shared CLI path

Create a single thumbnail capture path through captureSiteThumbnail() that is used by both the desktop UI (loadThemeDetails) and CLI events subscriber. This eliminates duplication and uses pendingCaptures deduplication to prevent concurrent BrowserWindow creation when the same site is captured by multiple paths simultaneously.

* remove comments

* Use sequential util with deduplicateKey for thumbnail capture

* Fix E2E copy-site test targeting wrong BrowserWindow

The thumbnail capture feature creates hidden BrowserWindows for
screenshots. The copy-site test used getAllWindows()[0] to send
the IPC event, which could target the screenshot window instead
of the main app window, causing the copy action to silently fail.
Use getFocusedWindow() with a visible-window fallback instead.

---------

Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>

* Disable Redis/memcached when JSPI is unavailable (#2900)

* Disable Redis and memcached PHP extensions when JSPI is unavailable

These extensions require JSPI (JavaScript Promise Integration), which is
only available in Node.js 24+. On Node <24, enabling them crashes the
WordPress server at startup. This conditionally disables them when JSPI
isn't available, matching the pattern in process-manager-daemon.ts.

Also bumps the minimum engine version to >=24.0.0 since the production
build strips asyncify binaries, making Node 24+ a de facto requirement.

* Revert engine version bump to >=22.0.0

* Sort sites by sortOrder when loading from IPC (#2902)

* Fix regressions around deleting preview sites (#2903)

* Support deleting all preview sites from CLI and app

* Update tests

* Fix

* Improve schemas and types

* Tweak

* Fix JSPI detection using runtime feature check (#2906)

* Fix JSPI detection using runtime feature check instead of Node version

Replace semver.gte(process.version, '24.0.0') with a runtime check for
WebAssembly.promising to detect JSPI availability. The version check
assumed Node 24+ has JSPI enabled by default, but it requires the
--experimental-wasm-jspi flag. This caused "Redis extension requires
JSPI" errors when running CLI commands directly without the flag.

Extract the check into a shared isJspiAvailable helper in
tools/common/lib/jspi.ts so there is a single source of truth.

* Remove unverified claim about JSPI proposal stage from comment

* Fix linting

* Address review suggestions

* Pass `--experimental-wasm-jspi` to node in bin script

---------

Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7-beta2

* Minuscule CLI README tweak (#2917)

* Minuscule CLI README tweak

* Fix tests

* Address review comments

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json` (#2916)

* Rename `appdata-v1.json` to `appdata-v1.deprecated.json`

* Fix tests

* Fix tests

* Fix tests

* Fix What's New current step icon color in dark mode (#2921)

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Update release notes for 1.7.7 (#2905)

* Update release notes for 1.7.7

* Address review suggestions

* Ensure that language packs are bundled in `wp-files` (#2922)

* Add phpMyAdmin to What's New dialog (#2920)

* Add phpMyAdmin to What's New dialog

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* Improve wording

* Force What's New for next version

* Update phpMyAdmin illustration with dot grid background

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>

* Refactor and clean up site deletion logic in app (#2915)

* Refactor site deletion in app

* Nit fix

* [skip ci] Bump version to 1.7.7-beta3

* Emit `deleted` site event when removing empty site (#2929)

* Bump CLI version

* [skip ci] Update translations

* [skip ci] Bump version to 1.7.7

* [skip ci] Bump CLI version to 1.7.7

---------

Co-authored-by: Roberto Aranda <roberto.aranda@automattic.com>
Co-authored-by: Shaun Andrews <shaun@automattic.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-authored-by: Wojtek Naruniec <wojtek@naruniec.me>
Co-authored-by: katinthehatsite <katerynakodonenko@gmail.com>
Co-authored-by: Kateryna Kodonenko <kateryna@automattic.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik.rombach.ekelund@automattic.com>
Co-authored-by: Gergely Csécsey <gergely.csecsey@automattic.com>
Co-authored-by: Ivan Ottinger <ivan.ottinger@automattic.com>
Co-authored-by: Bernardo Cotrim <bmmcotrim@gmail.com>
Co-authored-by: Fredrik Rombach Ekelund <fredrik@f26d.dev>
Co-authored-by: Antonio Sejas <antonio.sejas@automattic.com>
Co-authored-by: Wojtek Naruniec <wojtek.naruniec@automattic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants