Skip to content

Studio: Fix color of Learn more links in the dark mode #2857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
katinthehatsite merged 1 commit into from
Mar 20, 2026
Merged

Studio: Fix color of Learn more links in the dark mode #2857

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion apps/studio/src/components/learn-more.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { useI18n } from '@wordpress/react-i18n';
import Button from 'src/components/button';
import { cx } from 'src/lib/cx';
import { getIpcApi } from 'src/lib/get-ipc-api';
import { getLocalizedLink, type DocsLinkKey } from 'src/lib/get-localized-link';
import { useI18nLocale } from 'src/stores';
Expand All @@ -15,7 +16,7 @@ function MoreLink( { docsLinksKey, className, label }: LinkProps & { label: stri

return (
<Button
className={ className }
className={ cx( 'learn-more-link', className ) }
onClick={ ( e: React.MouseEvent ) => {
e.stopPropagation();

Expand Down
8 changes: 8 additions & 0 deletions apps/studio/src/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,6 +446,14 @@ div:has( > progress ) > div:first-child {
color: var( --color-frame-theme );
}

/* External doc links (Learn more / Learn how) always render in theme blue */

@nightnei nightnei Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add these styles here ?

@nightnei nightnei Mar 20, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should keep consistency and all browser links should have the same color, e.g.
Screenshot 2026-03-20 at 10 30 26

@katinthehatsite katinthehatsite Mar 20, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our best approach would be to keep the consistency with the light mode:

Screenshot 2026-03-20 at 11 51 43 AM

What do you think?

@gcsecsey gcsecsey Mar 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also think it's better to keep it consistent with the light theme, and to keep the open links also consistent, similar color to eg. the inactive tab color.
.components-button.is-link.learn-more-link:not( .is-destructive ) {
color: var( --color-frame-theme );
}
.components-button.is-link.learn-more-link:not( .is-destructive ):hover {
color: var( --color-frame-theme-hover );
}

/* Button SVG icons */
.components-button svg {
fill: var( --color-frame-text );
Expand Down
Loading