Skip to content

Add command for deselecting site - #2859

Open
mtias wants to merge 1 commit into
trunkfrom
add/site-deselect
Open

Add command for deselecting site#2859
mtias wants to merge 1 commit into
trunkfrom
add/site-deselect

Conversation

@mtias

@mtias mtias commented Mar 20, 2026

Copy link
Copy Markdown
Member

We may want to explore allowing esc key while on site list to do this, but it may be too hidden

@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 29b3dd6 vs trunk

app-size

Metric trunk 29b3dd6 Diff Change
App Size (Mac) 1236.62 MB 1236.63 MB +0.00 MB ⚪ 0.0%

site-editor

Metric trunk 29b3dd6 Diff Change
load 1918 ms 1883 ms 35 ms ⚪ 0.0%

site-startup

Metric trunk 29b3dd6 Diff Change
siteCreation 7109 ms 6119 ms 990 ms 🟢 -13.9%
siteStartup 3925 ms 3923 ms 2 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mtias! 👋 This has been open with no movement for a while. Is deselecting the active site still something we want to add? If so, I'm happy to rebase it and fix it up, otherwise I think we can close it. WDYT?

@wojtekn

wojtekn commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Marking as draft until tests and conflicts are solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants