Skip to content

Use sidebar chrome color for onboarding left panel in dark mode - #2865

Merged
gcsecsey merged 1 commit into
trunkfrom
stu-1433-use-sidebar-chrome-color-for-onboarding-left-panel-in-dark
Mar 20, 2026
Merged

Use sidebar chrome color for onboarding left panel in dark mode#2865
gcsecsey merged 1 commit into
trunkfrom
stu-1433-use-sidebar-chrome-color-for-onboarding-left-panel-in-dark

Conversation

@sejas

@sejas sejas commented Mar 20, 2026

Copy link
Copy Markdown
Member

Related issues

How AI was used in this PR

Claude identified the relevant Tailwind color tokens and applied dark:bg-chrome and dark:from-chrome/dark:to-chrome variants to the onboarding left panel. Changes were reviewed before committing.

Proposed Changes

This is not too critical as the default color is light, so currently users won't see the onboarding on dark mode, but it's better to keep improving the dark mode screens.

  • Update the onboarding screen for dark mode by changing the left panel blue to black.

Testing Instructions

  • Remove the "onboardingCompleted": true and set "colorScheme": "dark" in ~/Library/Application\ Support/Studio/appdata-v1.json
  • Remove all your sites to see the onboarding screen
  • Start the app with npm start
  • Verify the left panel background is dark (#1E1E1E) instead of blue
  • Switch to light mode and verify the left panel is still blue as before
Before After
Screenshot 2026-03-20 at 13 18 38 Screenshot 2026-03-20 at 13 23 05

Pre-merge Checklist

  • Have you checked for TypeScript, React or other console errors?
@sejas sejas self-assigned this Mar 20, 2026
@sejas
sejas requested a review from a team March 20, 2026 13:27
Fixes STU-1433

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@sejas
sejas force-pushed the stu-1433-use-sidebar-chrome-color-for-onboarding-left-panel-in-dark branch from 5b6b4ba to 9db63f1 Compare March 20, 2026 13:33
@wpmobilebot

Copy link
Copy Markdown
Collaborator

📊 Performance Test Results

Comparing 9db63f1 vs trunk

app-size

Metric trunk 9db63f1 Diff Change
App Size (Mac) 1236.63 MB 1236.63 MB 0.00 MB ⚪ 0.0%

site-editor

Metric trunk 9db63f1 Diff Change
load 1893 ms 1934 ms +41 ms ⚪ 0.0%

site-startup

Metric trunk 9db63f1 Diff Change
siteCreation 6112 ms 7116 ms +1004 ms 🔴 16.4%
siteStartup 3937 ms 3912 ms 25 ms ⚪ 0.0%

Results are median values from multiple test runs.

Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff)

@gcsecsey gcsecsey left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this @sejas! The updated color LGTM. 👍

Image
@gcsecsey
gcsecsey merged commit 7e8c538 into trunk Mar 20, 2026
11 checks passed
@gcsecsey
gcsecsey deleted the stu-1433-use-sidebar-chrome-color-for-onboarding-left-panel-in-dark branch March 20, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants