Remove feature flag from AI instructions install in CLI - #2886
Merged
Conversation
The desktop app already calls installAiInstructionsToSite without a feature flag. Align the CLI path so AI instructions (AGENTS.md, etc.) are installed unconditionally when creating a site via CLI. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Site creation in the desktop app goes through SiteServer.create() which calls createSiteViaCli() internally. The CLI create command already installs AI instructions, so the separate call in ipc-handlers was redundant and would install instructions twice. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
sejas
marked this pull request as ready for review
March 24, 2026 14:04
Collaborator
📊 Performance Test ResultsComparing 36d38d8 vs trunk app-size
site-editor
site-startup
Results are median values from multiple test runs. Legend: 🟢 Improvement (faster) | 🔴 Regression (slower) | ⚪ No change (<50ms diff) |
Member
Author
|
I created another PR that would be great to include #2889 , it keeps updated STUDIO.md when site starts from CLI. |
fredrikekelund
approved these changes
Mar 24, 2026
fredrikekelund
left a comment
fredrikekelund
left a comment
Contributor
There was a problem hiding this comment.
This is great 👍 Thanks, @sejas. Works as expected
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issues
How AI was used in this PR
Claude identified that the desktop app already installs AI instructions without a feature flag, while the CLI path was still gated behind
ENABLE_AGENT_SUITE. The change was pair-programmed with Claude.Proposed Changes
installAiInstructionsToSite()in the CLIsite createcommandTesting Instructions
From CLI
npm run cli:buildENABLE_AGENT_SUITE:node apps/cli/dist/cli/main.js site create /tmp/test-siteAGENTS.md,CLAUDE.md, andSTUDIO.mdexist in the site rootFrom Desktop
npm startAGENTS.md,CLAUDE.md, andSTUDIO.mdexist in the site rootadd-agents-md-from-studio-cli.mp4
Pre-merge Checklist